Skip to content

fix: allow custom Azure OpenAI model names - #6643

Open
wanxiankai wants to merge 1 commit into
FlowiseAI:mainfrom
wanxiankai:fix/azure-openai-custom-model-name
Open

fix: allow custom Azure OpenAI model names#6643
wanxiankai wants to merge 1 commit into
FlowiseAI:mainfrom
wanxiankai:fix/azure-openai-custom-model-name

Conversation

@wanxiankai

Copy link
Copy Markdown

Summary

  • Preserve freeSolo string values from MUI Autocomplete in shared dropdown components.
  • Keep custom async dropdown values visible when they do not match a predefined option.
  • Allow the deprecated Azure OpenAI LLM node model selector to accept custom deployment/model names.

Validation

  • corepack pnpm exec eslint packages/ui/src/ui-component/dropdown/AsyncDropdown.jsx packages/ui/src/ui-component/dropdown/Dropdown.jsx "packages/components/nodes/llms/Azure OpenAI/AzureOpenAI.ts"
  • corepack pnpm --filter flowise-ui build
  • corepack pnpm --filter flowise-components build

Closes #6590

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables free-text input (freeSolo mode) for the Azure OpenAI model name selection and updates the AsyncDropdown and Dropdown components to support custom string values. However, in both dropdown components, the underlying TextField has its value prop explicitly bound to internalValue, which locks the input and prevents users from typing custom values freely. The feedback suggests removing this binding and using a placeholder to let the Autocomplete component manage its typing state internally.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

}}
options={options}
value={findMatchingOptions(options, internalValue) || getDefaultOptionValue()}
value={getAutocompleteValue(options, internalValue)}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While enabling freeSolo is intended to allow custom text input, the underlying TextField (line 235) has value={internalValue} explicitly set. Because internalValue is only updated on onChange (when a selection is committed), this binding locks the input field and prevents users from typing custom values freely.

To fix this, the value={internalValue} prop should be removed from the TextField inside renderInput, allowing Autocomplete to manage the input's temporary typing state internally. You can use placeholder to show the default helper text instead:

placeholder={internalValue === 'choose an option' ? 'choose an option' : ''}

loading={loading}
options={options || []}
value={findMatchingOptions(options, internalValue) || getDefaultOptionValue()}
value={getAutocompleteValue(options, internalValue)}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While enabling freeSolo is intended to allow custom text input, the underlying TextField (line 58) has value={internalValue} explicitly set. Because internalValue is only updated on onChange (when a selection is committed), this binding locks the input field and prevents users from typing custom values freely.

To fix this, the value={internalValue} prop should be removed from the TextField inside renderInput, allowing Autocomplete to manage the input's temporary typing state internally. You can use placeholder to show the default helper text instead:

placeholder={internalValue === 'choose an option' ? 'choose an option' : ''}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Azure OpenAI: custom/deployed model names not selectable in "Model Name" dropdown

1 participant