Improve passing of ui_update.chartOptions to clients to prevent memory growing unrestricted

nodes/widgets/ui_chart.js

@@ -165,6 +165,8 @@ module.exports = function (RED) {
                         // Deep merge new options in with old
                         const mergedOptions = deepMerge(currentOptions, updates.chartOptions)
                         statestore.set(group.getBase(), node, msg, 'chartOptions', mergedOptions)
+                        // pass the full set to the clients so they don't need to do the merge
+                        msg.ui_update.chartOptions = mergedOptions
                     }
                 }
 

ui/src/widgets/ui-chart/UIChart.vue

@@ -34,7 +34,6 @@
             },
             chartUpdateDebounceTimeout: null,
             tooltipDataset: [],
-            dynamicChartOptions: [], // an array of chart options updates received this session
             resizeObserver: null
         }
     },
@@ -193,8 +192,6 @@
                 if (this.chart) {
                     this.chart.setOption(updates.chartOptions)
                 }
-                // add these options to the array of previous updates received this session
-                this.dynamicChartOptions.push(updates.chartOptions)
             }
         },
         generateChartOptions () {
@@ -433,10 +430,6 @@
                         if (chartOptions) {
                             this.chart.setOption(chartOptions)
                         }
-                        // then from this session
-                        this.dynamicChartOptions.forEach((options) => {
-                            this.chart.setOption(options)
-                        })
                     }
                 }
             }
@@ -748,10 +741,10 @@
         updateYAxisLimits (options) {
             if (this.hasData && this.props.xAxisType !== 'radial') {
                 if (!Object.hasOwn(this.props, 'ymin') || this.props.ymin === '' || typeof this.props.ymin === 'undefined') {
                     options.yAxis[0].min = axisHelper.getAxisMin // set sensible y-limits
                 }
                 if (!Object.hasOwn(this.props, 'ymax') || this.props.ymax === '' || typeof this.props.ymax === 'undefined') {
                     options.yAxis[0].max = axisHelper.getAxisMax // set sensible y-limits
                 }
             }
         },