Skip to content

[7324] Replace HTTP polling of instance / device status with MQTT-over-WS #7347

Draft
n-lark wants to merge 2 commits into
7320-mqtt-teamfrom
7324-replace-polling-mqtt/ws
Draft

[7324] Replace HTTP polling of instance / device status with MQTT-over-WS #7347
n-lark wants to merge 2 commits into
7320-mqtt-teamfrom
7324-replace-polling-mqtt/ws

Conversation

@n-lark
Copy link
Copy Markdown
Contributor

@n-lark n-lark commented May 26, 2026

Description

Moved this to blocked - want #7257 done first, see #7324 (comment)

⚠️ This is cut from #7327 - will need that to merge first.

See #7324

Related Issue(s)

Resolves #7324

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@n-lark n-lark self-assigned this May 26, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

❌ Patch coverage is 73.68421% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.46%. Comparing base (9a4001a) to head (29bfb5f).
⚠️ Report is 6 commits behind head on 7320-mqtt-team.

Files with missing lines Patch % Lines
forge/comms/index.js 35.71% 9 Missing ⚠️
forge/comms/aclManager.js 90.00% 4 Missing ⚠️
forge/comms/commsClient.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           7320-mqtt-team    #7347      +/-   ##
==================================================
- Coverage           76.47%   76.46%   -0.01%     
==================================================
  Files                 405      405              
  Lines               20694    20750      +56     
  Branches             5010     5027      +17     
==================================================
+ Hits                15825    15867      +42     
- Misses               4869     4883      +14     
Flag Coverage Δ
backend 76.46% <73.68%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

})
this.syncMqttSubscriptions(this.instancesMap.keys(), this.mqttAvailable, this.onMqttStateMessage)
})
.then(() => this.getInstanceMeta())
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still n queries here on initial load - consider other options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant