feat(installer): Prompt for the Device Agent port in interactive mode - #739
Open
ppawlowski wants to merge 8 commits into
Open
ppawlowski wants to merge 8 commits into
ppawlowski wants to merge 8 commits into
Conversation
Contributor
|
one v minor niggle - the line "The FlowFuse Device Agent will use port 1888." is output after user choice, but there is no equivalent "Install Dir: C:\opt\flowfuse-device-1888" output after the directory choice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This pull request adds a port question to the installer's interactive mode, so a Remote Instance integrator can choose which TCP port the Device Agent binds to without having to know the
--portflag up front. The installer asks for theport straight after the permission check and re-asks until the answer is a free port in the 1025-65535 range. Passing
--portstill works unchanged and skips the question, reporting only which port will be used.--portis now a nullable flag value, so an explicit--port 1880stays distinguishable from an omitted flag, and range validation moved into the flag type - also lets pflag reject a bad value itself and corrects the helptext, previously advertised as
1-65535while the guard rejected anything below 1025.When the chosen port is not the default, the installation directory offered by the next question carries it (
/opt/flowfuse-device-1881), so agents on different ports are not proposed the same location. It remains a suggestion and any absolute path can be typed instead. Scripted installations driven by--otcstay non-interactive throughout and keep the plain default directory.Additionally, this pull request:
utilspackageRelated Issue(s)
Closes #730
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel