Fold the probes and models tables behind a summary row - #157
Merged
Merged
Conversation
With the charts above them giving the overview, the two long tables now start collapsed. Each sits in a <details> whose summary row names it with its counts, read off the rendered rows: "Probe table: 35 merged, 4 on the roadmap" and "Model table: 10 models". A Show/Hide hint and a chevron turn with the state. It is native disclosure, so it works by keyboard without script. The labels are in en/es/zh, and the status and column legends stay outside the fold.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation matches the stated behavior without introducing correctness or accessibility issues.
Review effort: Balanced
Findings: None
What changed in this PR
Collapses the long probe and model tables behind native, localized disclosure controls while preserving chart behavior.
Changes:
- Adds styled, keyboard-accessible
<details>wrappers. - Generates localized summary labels from rendered row counts.
- Keeps legends and explanatory notes outside collapsed content.
| File | Description |
|---|---|
site/index.html |
Adds collapsible tables, localized labels, styling, and dynamic counts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Barbhuiya12
added a commit
to Barbhuiya12/hydroturing
that referenced
this pull request
Oct 2, 2026
…nowpack-ripening Conflicts in README.md, models/result.csv and site/index.html. Counts are re-derived for both probes: thirty-six, twenty-three mass, eight energy, five momentum. The flowchart keeps main's taller pillars with the ripening entry in the energy one. sacsma_snow17 1.2.0 is archived on mass/groundwater-datum-invariance (N/A) after main's 1.1.0 row, and modflow6 6.7.0-adapter.2 on this probe (N/A); the site chart data is regenerated with scripts/site_standings.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #156. The charts now give the overview, so the two long tables on the site start collapsed.
<details>. Its summary row names the table with counts read from the rendered rows: "Probe table: 35 merged, 4 on the roadmap" and "Model table: 10 models, what each one is and its verdict". The counts stay right as rows are added, with nothing to keep in sync by hand.Checked
tests/test_docs_in_sync.py: 241 passed.scripts/site_standings.py --check: clean.