Conversation
Contributor
Author
|
@fumiama 这个workflows是不是有点问题？🤔 |
Member
|
要升级一下CI用的Go版本。等我闲了搞一下，你也可以自己改改。 |
fumiama
requested changes
Sep 24, 2026
| } | ||
|
|
||
| // FetchPixivImage 直接从 Pixiv 下载图片 | ||
| func (c *Client) FetchPixivImage(illust model.IllustCache, url string) ([]byte, error) { |
| ) | ||
|
|
||
| // IllustCache 插画缓存表 | ||
| type IllustCache struct { |
| } | ||
|
|
||
| // FetchPixivByPID ... | ||
| func (p *PixivAPI) FetchPixivByPID(pid int64) (*model.IllustCache, error) { |
Member
There was a problem hiding this comment.
都是pixiv API了，不必再包含pixiv，其他地方同理。
| } | ||
|
|
||
| // GetIllustsByKeyword ... | ||
| func (p *PixivAPI) GetIllustsByKeyword(keyword string, limit int, cachedIllust []model.IllustCache, cached []int64) ([]model.IllustCache, error) { |
Member
There was a problem hiding this comment.
不应在此杂糅cached逻辑。可直接传入need几张图片，由调用者判断。
| ) | ||
|
|
||
| // TokenStore ... | ||
| type TokenStore struct { |
Member
There was a problem hiding this comment.
建议全部通过函数方式获取值，变量全部改为private，这样方便做一些中间处理。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.