Child curations - backend. by LindirQuenya · Pull Request #321 · FlashpointProject/launcher

LindirQuenya · 2022-04-01T00:04:28Z

The backend changes for #245.

~~Also, switch to better-sqlite3: performance was suffering without it, and I can't see a reason to stick with a slower version of the same functionality.~~ Nope, better-sqlite3 doesn't do migrations correctly. It's been reverted.

For the testing: I've begun with rewriting the tests for GameManager.ts. I'm not too clear on how to test things beyond that... we'll see.

…children, fix a few typos, and a few small bugfixes.

I was getting meh performance with sqlite3, and I heard better-sqlite3 was faster. It seems to be so.

coveralls · 2022-04-01T00:07:53Z

Pull Request Test Coverage Report for Build 2234249069

49 of 134 (36.57%) changed or added relevant lines in 9 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-21.3%) to 38.855%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/back/GameLauncher.ts	2	8	25.0%
src/back/util/misc.ts	1	12	8.33%
src/shared/curate/metaToMeta.ts	1	13	7.69%
src/back/importGame.ts	3	30	10.0%
src/back/game/GameManager.ts	21	50	42.0%

Totals
Change from base Build 2011998412:	-21.3%
Covered Lines:	1201
Relevant Lines:	2730

💛 - Coveralls

LindirQuenya · 2022-04-01T03:06:15Z

Things I currently know that I need to fix:

Native overrides in execs.json don't seem to work with children.
Extras need to be fixed.
A whole bunch of strings need to be added.
All backend tests need to be rewritten.
ESLint messages should be addressed.
Curation needs to be tested.
Importing needs to be tested.
The game counter at the bottom needs fixing.
The game data browser is broken?

That is: I hope so. I haven't tested curation yet, but I *think* this will fix some portions of it.

Previously, the blank platform strings of children were included in the results of findPlatforms().

Also make some == into ===, and make the message bar appear in when browsing.

LindirQuenya · 2022-04-02T23:09:33Z

In case you're wondering about the point of b49d9c1: in my testing, it looked like typeorm doesn't translate undefined properties to NULL in the database - in fact, it doesn't seem to touch them at all. This (kinda old) comment suggests that this is intentional - we will need to actually set the property to null if we want it to be NULL in the DB.

This reverts commit c64d1f7.

LindirQuenya · 2022-04-07T00:55:32Z

better-sqlite3 wasn't running the migrations properly on Windows, so I've reverted c64d1f7. Performance is less important than the launcher working on Windows.

This reverts commit c64d1f7.

Remove some temporary statements, and add a relation-loading statement for the tags of child games.

Previously, the param was marked as optional. However, failure to supply it resulted in an error (column not found).

Switch the comparison for keyset pagination when orderBy is different.

Don't open a new database connection if one already exists, and don't close the connection at the end of testing.

Also: add some jsdoc and a possible todo, and remove an unneeded selected colum.

Also switch filtering funcs to === from ==.

Also clean up some TODOs.

Implement the child edit function and turn on cascades for children. Set the default child modified and added dates to the unix epoch. Previously, the all-zeroes date was resulting in a null datetime object.

Also remove some todos.

…-updated

LindirQuenya · 2022-05-27T01:14:59Z

That should bring it up to date with develop. The GameManager tests are in the wrong place though, one moment.

LindirQuenya added 10 commits March 29, 2022 18:57

chore: add nano swapfiles to gitignore.

f292444

First try, broken.

ec8bc92

Fix silly database mistake.

65cce7c

Searching and launching broken, but browsing works now.

5c0256b

Fix the extensions API.

019ea4e

Update deps, add migration.

63b08b9

Add migration at database init.

03e069a

Fix child-loading, make children[] nullable, add option not to fetch …

87c445a

…children, fix a few typos, and a few small bugfixes.

perf: don't fetch the game twice.

2f10d62

build: switch to better-sqlite3

c64d1f7

I was getting meh performance with sqlite3, and I heard better-sqlite3 was faster. It seems to be so.

LindirQuenya changed the title ~~Child curations.~~ Child curations - backend. Apr 1, 2022

Fix comment for removeGameAndChildren()

3a01d1d

LindirQuenya added 6 commits April 1, 2022 12:26

Fix extras.

bba3e86

Make the linter happy, also fix curation.

1ad82e7

That is: I hope so. I haven't tested curation yet, but I *think* this will fix some portions of it.

fix: child launching - children inherit on empty platform.

4214be3

Update the download button on child launch.

cc824b1

Add option in findPlatforms to exclude children.

8db0b55

Previously, the blank platform strings of children were included in the results of findPlatforms().

Make the nullable properties actually nullable.

b49d9c1

Also make some == into ===, and make the message bar appear in when browsing.

LindirQuenya added 2 commits April 2, 2022 19:10

Make the linter happy about b49d9c1.

a88c90e

Add new lang strings for English.

6999c0c

LindirQuenya marked this pull request as ready for review April 3, 2022 02:19

LindirQuenya added 5 commits April 2, 2022 22:40

Give extras launch button its own section in sidebar.

bf035a0

Fix game count update on delete, remove TODOs.

2467415

Fix game data browser for single-pack games.

8778191

Fix getRootPath()

8dda528

Revert "build: switch to better-sqlite3"

cffe768

This reverts commit c64d1f7.

LindirQuenya added 25 commits May 26, 2022 19:39

Make the linter happy about b49d9c1.

0f78d9f

Add new lang strings for English.

5c4f3b9

Give extras launch button its own section in sidebar.

a636b11

Fix game count update on delete, remove TODOs.

4e1dffc

Fix game data browser for single-pack games.

e881b5b

Fix getRootPath()

f769588

Revert "build: switch to better-sqlite3"

db0bbc7

This reverts commit c64d1f7.

fix: load tags for children. Also: slight cleanup.

6bf3138

Remove some temporary statements, and add a relation-loading statement for the tags of child games.

test: GameManager: findGame() and countGames().

5b0a8fa

fix: make orderBy required in findGameRow()

2614e61

Previously, the param was marked as optional. However, failure to supply it resulted in an error (column not found).

fix: findGameRow() keyset pagination directions

0cf811f

Switch the comparison for keyset pagination when orderBy is different.

test: GameManager.findGameRow()

d6ab6aa

style: make the linter happy

ee5878e

test: allow connection to be managed outside

0bd6f4b

Don't open a new database connection if one already exists, and don't close the connection at the end of testing.

fix: sorting for findGamePageKeyset()

1d05994

Also: add some jsdoc and a possible todo, and remove an unneeded selected colum.

test: GameManager.findGamePageKeyset()

3d629f2

Also switch filtering funcs to === from ==.

feat: restore DUPLICATE_GAME.

87efa4a

Also clean up some TODOs.

make the linter happy

46fa961

fix: implement child editing, fix default date.

9af7406

Implement the child edit function and turn on cascades for children. Set the default child modified and added dates to the unix epoch. Previously, the all-zeroes date was resulting in a null datetime object.

fix: check that extras exist before importing

5aec01e

Also remove some todos.

style: make the linter happy

deb8a5a

style: remove a bunch of irrelevant todos

9d73b79

fix: explictly cast an error to a string, so that it will compile

f62ec64

Supress the undefined and null errors.

55d8bbc

Merge branch 'FlashpointProject-develop' into feature/child-curations…

e3bcdb9

…-updated

LindirQuenya added 3 commits May 26, 2022 21:16

Move the GameManager tests to the right place

8ccc0f3

Make db-creation code shared.

d4d2e47

Organize imports

f1e5078

LindirQuenya mentioned this pull request Jul 1, 2022

[BUG] Add-Apps do not follow App Path Overrides #156

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Child curations - backend.#321

Child curations - backend.#321
LindirQuenya wants to merge 84 commits intoFlashpointProject:developfrom
LindirQuenya:feature/child-curations-updated

LindirQuenya commented Apr 1, 2022 •

edited

Loading

Uh oh!

coveralls commented Apr 1, 2022 •

edited

Loading

Uh oh!

LindirQuenya commented Apr 1, 2022 •

edited

Loading

Uh oh!

LindirQuenya commented Apr 2, 2022

Uh oh!

LindirQuenya commented Apr 7, 2022

Uh oh!

LindirQuenya commented May 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

LindirQuenya commented Apr 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Apr 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 2234249069

💛 - Coveralls

Uh oh!

LindirQuenya commented Apr 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LindirQuenya commented Apr 2, 2022

Uh oh!

LindirQuenya commented Apr 7, 2022

Uh oh!

LindirQuenya commented May 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LindirQuenya commented Apr 1, 2022 •

edited

Loading

coveralls commented Apr 1, 2022 •

edited

Loading

LindirQuenya commented Apr 1, 2022 •

edited

Loading