Skip to content

test(Segments): Run the segment audit log E2E test on SaaS again #8919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
khvn26 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test(Segments): Run the segment audit log E2E test on SaaS again #8919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions frontend/e2e/helpers/utils.playwright.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,3 @@ export const getFlagsmith = async function (): Promise<IFlagsmith> {
await initProm;
return flagsmith as IFlagsmith;
};

// Whether the API under test is a SaaS deployment, per its `/version/` endpoint.
export const isSaas = async function (): Promise<boolean> {
const api = process.env.FLAGSMITH_API_URL || Project.api;
const res = await fetch(`${api.replace(/api\/v1\/$/, '')}version/`);
const version = (await res.json()) as { is_saas?: boolean };
return !!version.is_saas;
};
6 changes: 1 addition & 5 deletions frontend/e2e/tests/segment-test.pw.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { test, expect } from '../test-setup';
import { byId, log, createHelpers, visualSnapshot, getFlagsmith, isSaas } from '../helpers';
import { byId, log, createHelpers, visualSnapshot, getFlagsmith } from '../helpers';
import { E2E_USER, PASSWORD, E2E_TEST_IDENTITY, E2E_SEGMENT_PROJECT_1, E2E_SEGMENT_PROJECT_2, E2E_SEGMENT_PROJECT_3 } from '../config'

const REMOTE_CONFIG_FEATURE = 'remote_config'
Expand Down Expand Up @@ -477,10 +477,6 @@ test('Segment test 4 - Create ANY rule type segment and verify match changes whe
})

test('Segment test 5 - Audit log shows segment rule changes @enterprise', async ({ page }) => {
test.skip(
await isSaas(),
'The E2E organisation has no audit log visibility on SaaS until the seeded subscription is deployed',
)
const {
click,
createSegment,
Expand Down
Loading