You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(E2E): Lift the E2E organisation's plan limits on SaaS - #8918
Fix the reason for the test to fail in the first place: a seeded enterprise org's subscription cache was not updated to reflect the lifted limits, which included the audit log visibility limit. This will allow us to unskip the test in a follow-up PR after the next release.
How did you test this code?
Ran the E2E Segment 5 test against SaaS to confirm green; ran the original test against a properly seeded organisation to confirm green.
On SaaS, plan limits such as audit log visibility come from the
subscription information cache, which the seed left on free plan
limits. The E2E organisation therefore saw no audit logs.
Upgrade the cache to enterprise limits when one exists.
The seed data now upgrades the organisation’s subscription-information caches to Enterprise using the subscription’s seat and API-call limits. Unit tests check the SaaS cache values and verify that no cache is created without the SaaS marker. The frontend adds an API-based SaaS check and uses it to skip the audit-log segment test in SaaS mode.
The cache upgrade restores seeded audit visibility, but some deployment configurations can still fail the tests, and SaaS continues to skip the audit regression assertion. Merge risk is low, with these bounded test limitations requiring owner awareness or follow-up.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.90%. Comparing base (a002217) to head (41913d9). ⚠️ Report is 1 commits behind head on main.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
In this PR, we:
How did you test this code?
Ran the E2E
Segment 5test against SaaS to confirm green; ran the original test against a properly seeded organisation to confirm green.