feat(__future__): Identify MV options by key in experimental update-flags endpoint by emyller · Pull Request #8000 · Flagsmith/flagsmith

emyller · 2026-07-13T21:50:18Z

Thanks for submitting a PR! Please check the boxes below:

I have read the Contributing Guide.
I have added information to docs/ if required so people know about the feature.
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.

Changes

Timeline for context

New — and experimental — update-flag endpoints were introduced as Options A and B (feat(api): add experimental feature flag update endpoints #6305).
The experimentation team added a new "key" attribute to identify multivariate options (feat(multivariate): add per-feature unique key to multivariate options #7698).
The update-flag endpoints got full MV support (feat(__future__): Add MV capabilities to the experimental update-flag endpoints #7955).
This PR adds the ability to use MV keys in the update-flag endpoints.

Changes

Contributes to #7642

Similarly to how a feature can be identified in the experimental update-flag endpoints, i.e. by either its ID or name, now we allow multivariate options to be identified by either their ID or [the new] key.

This means to make it easier to use update-flag, eliminating retrieving an MV ID as an extra step to achieving the use case of updating or re-weighting multivariates.

How did you test this code?

New tests.

vercel · 2026-07-13T21:50:24Z

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs	Ignored	Preview	Jul 14, 2026 12:45am
flagsmith-frontend-preview	Ignored	Preview	Jul 14, 2026 12:45am
flagsmith-frontend-staging	Ignored	Preview	Jul 14, 2026 12:45am

coderabbitai · 2026-07-13T21:50:25Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fc5bd214-f490-4501-985e-73f90eb96458

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-13T22:33:23Z

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-e2e:pr-8000`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-api-test:pr-8000`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-frontend:pr-8000`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-8000`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-8000`	Finished ✅	Results ✅

github-actions · 2026-07-13T22:39:09Z

Playwright Test Results (oss - depot-ubuntu-latest-16)

5 passed

Details

5 tests across 3 suites
39.4 seconds
9e5c9cb
🔄 Run: #18218 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

4 passed

Details

4 tests across 3 suites
45.8 seconds
9e5c9cb
🔄 Run: #18218 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

4 passed

Details

4 tests across 3 suites
40.4 seconds
9e5c9cb
🔄 Run: #18218 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

4 passed

Details

4 tests across 4 suites
1 minute, 1 second
9e5c9cb
🔄 Run: #18218 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

4 passed

Details

4 tests across 3 suites
45.6 seconds
31389bf
🔄 Run: #18219 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

4 passed

Details

4 tests across 3 suites
12.4 seconds
31389bf
🔄 Run: #18219 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

8 passed

Details

8 tests across 6 suites
1 minute, 14 seconds
31389bf
🔄 Run: #18219 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
1 minute, 2 seconds
31389bf
🔄 Run: #18219 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

4 passed

Details

4 tests across 3 suites
17.7 seconds
0c2b855
🔄 Run: #18220 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

4 passed

Details

4 tests across 3 suites
45.1 seconds
0c2b855
🔄 Run: #18220 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

5 passed

Details

5 tests across 4 suites
33.2 seconds
0c2b855
🔄 Run: #18220 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

5 passed

Details

5 tests across 4 suites
40.9 seconds
0c2b855
🔄 Run: #18220 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

4 passed

Details

4 tests across 3 suites
42.4 seconds
541931c
🔄 Run: #18221 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

4 passed

Details

4 tests across 3 suites
45.3 seconds
541931c
🔄 Run: #18221 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

3 passed

Details

3 tests across 2 suites
40.4 seconds
541931c
🔄 Run: #18221 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

5 passed

Details

5 tests across 4 suites
1 minute, 2 seconds
541931c
🔄 Run: #18221 (attempt 1)

github-actions · 2026-07-13T22:40:04Z

Visual Regression

19 screenshots compared. See report for details.
View full report

codecov · 2026-07-13T22:51:35Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.64%. Comparing base (e75e61c) to head (541931c).

Additional details and impacted files

@@                           Coverage Diff                            @@
##           feat/multivariate-update-flag-endpoints    #8000   +/-   ##
========================================================================
  Coverage                                    98.64%   98.64%           
========================================================================
  Files                                         1498     1498           
  Lines                                        59410    59494   +84     
========================================================================
+ Hits                                         58604    58688   +84     
  Misses                                         806      806

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

khvn26 · 2026-07-14T16:38:04Z

+def _validate_overrides_reweight_environment_options(
+    feature: Feature,
+    environment_multivariate_values: Sequence[EnvironmentMultivariateValuePayload],
+    override_multivariate_value_lists: Sequence[
+        Sequence[SegmentOverrideMultivariateValuePayload]
+    ],
+) -> None:
+    option_id_by_key: dict[str, int] = {
+        key: option_id
+        for key, option_id in feature.multivariate_options.filter(
+            key__isnull=False
+        ).values_list("key", "id")
+        if key is not None
+    }
+    allowed_keys = {mv["key"] for mv in environment_multivariate_values if "key" in mv}
+    allowed_option_ids = {
+        mv["multivariate_feature_option"]
+        for mv in environment_multivariate_values
+        if "multivariate_feature_option" in mv
+    } | {option_id_by_key[key] for key in allowed_keys if key in option_id_by_key}
+    for multivariate_values in override_multivariate_value_lists:
+        for mv in multivariate_values:
+            if "multivariate_feature_option" in mv:
+                allowed = mv["multivariate_feature_option"] in allowed_option_ids
+            else:
+                allowed = (
+                    mv["key"] in allowed_keys
+                    or option_id_by_key.get(mv["key"]) in allowed_option_ids
+                )
+            if not allowed:
+                raise serializers.ValidationError(
+                    {
+                        "multivariate_feature_state_values": [
+                            "Segment overrides can only re-weight existing variants."
+                        ]
+                    }
+                )


Can you explain why we need this together with _validate_multivariate_keys_exist?

emyller self-assigned this Jul 13, 2026

github-actions Bot added api Issue related to the REST API docs Documentation updates feature New feature or request and removed docs Documentation updates feature New feature or request labels Jul 13, 2026

emyller marked this pull request as ready for review July 13, 2026 22:32

emyller requested review from a team as code owners July 13, 2026 22:32

emyller requested review from matthewelwell and removed request for a team July 13, 2026 22:32

flagsmith-engineering Bot assigned matthewelwell Jul 13, 2026

github-actions Bot added feature New feature or request and removed feature New feature or request labels Jul 13, 2026

emyller requested a review from a team as a code owner July 13, 2026 22:37

github-actions Bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Jul 13, 2026

emyller force-pushed the feat/update-flags-identify-mvs-by-key branch from 31389bf to 0c2b855 Compare July 13, 2026 22:41

github-actions Bot added docs Documentation updates and removed feature New feature or request labels Jul 13, 2026

github-actions Bot added feature New feature or request and removed docs Documentation updates labels Jul 13, 2026

emyller added 3 commits July 13, 2026 21:44

identify MV options by key

e091ad7

fix tests

dbae555

update api spec

541931c

emyller force-pushed the feat/update-flags-identify-mvs-by-key branch from 0c2b855 to 541931c Compare July 14, 2026 00:45

github-actions Bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Jul 14, 2026

khvn26 reviewed Jul 14, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(future): Identify MV options by key in experimental update-flags endpoint#8000

feat(future): Identify MV options by key in experimental update-flags endpoint#8000
emyller wants to merge 3 commits into
feat/multivariate-update-flag-endpointsfrom
feat/update-flags-identify-mvs-by-key

emyller commented Jul 13, 2026

Uh oh!

vercel Bot commented Jul 13, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 13, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions Bot commented Jul 13, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 13, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 13, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jul 13, 2026 •

edited

Loading

Uh oh!

khvn26 Jul 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

emyller commented Jul 13, 2026

Changes

Timeline for context

Changes

How did you test this code?

Uh oh!

vercel Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docker builds report

Uh oh!

github-actions Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Uh oh!

github-actions Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual Regression

Uh oh!

codecov Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

khvn26 Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel Bot commented Jul 13, 2026 •

edited

Loading

coderabbitai Bot commented Jul 13, 2026 •

edited

Loading

github-actions Bot commented Jul 13, 2026 •

edited

Loading

github-actions Bot commented Jul 13, 2026 •

edited

Loading

github-actions Bot commented Jul 13, 2026 •

edited

Loading

codecov Bot commented Jul 13, 2026 •

edited

Loading