Skip to content

feat: add unique analytics IDs to experiment, metric, and warehouse buttons#7997

Merged
Zaimwa9 merged 3 commits into
mainfrom
feat/add-ids-to-experimentation-ctas
Jul 14, 2026
Merged

feat: add unique analytics IDs to experiment, metric, and warehouse buttons#7997
Zaimwa9 merged 3 commits into
mainfrom
feat/add-ids-to-experimentation-ctas

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor
  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Adds unique id attributes to buttons across the experiment wizard, metrics page, and warehouse setup so Amplitude autocapture can distinguish elements that share the same text label (e.g. multiple "Continue" and "Create Metric" buttons).

Experiment wizard — step-aware IDs on Continue, Back, Create Experiment, Split evenly, review Edit buttons, and Create Metric buttons in the measurement step.

Metrics page — IDs on Create Metric buttons (empty state vs listing), form submit/cancel, and per-row edit/delete in the metrics table.

Warehouse setup — IDs on Enable, config form save/cancel, connection card edit/delete/test/send-first-event.

Naming convention: {flow}-{context}-{action} (e.g. experiment-wizard-setup-continue, metrics-page-create, warehouse-config-save).

How did you test this code?

Typecheck (npm run typecheck) and lint (eslint --fix) pass with no new errors. Visual inspection of ID uniqueness across all three flows.

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner July 13, 2026 12:32
@Zaimwa9 Zaimwa9 requested review from talissoncosta and removed request for a team July 13, 2026 12:32
@vercel

vercel Bot commented Jul 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Jul 13, 2026 12:33pm
flagsmith-frontend-staging Ready Ready Preview, Comment Jul 13, 2026 12:33pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Jul 13, 2026 12:33pm

Request Review

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Jul 13, 2026
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7997 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7997 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7997 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7997 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7997 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-7997 Finished ✅ Results

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 59c5480d-dc52-4493-83c0-e2e0859bee12

📥 Commits

Reviewing files that changed from the base of the PR and between 267653f and cb05e10.

📒 Files selected for processing (10)
  • frontend/web/components/experiments/CreateMetricForm/CreateMetricForm.tsx
  • frontend/web/components/experiments/MetricSelectList/MetricSelectList.tsx
  • frontend/web/components/experiments/MetricsTable/MetricsTable.tsx
  • frontend/web/components/experiments/WizardNavButtons.tsx
  • frontend/web/components/experiments/steps/ReviewStep.tsx
  • frontend/web/components/experiments/steps/RolloutStep.tsx
  • frontend/web/components/pages/MetricsPage.tsx
  • frontend/web/components/pages/environment-settings/tabs/warehouse-tab/ConfigForm.tsx
  • frontend/web/components/pages/environment-settings/tabs/warehouse-tab/WarehouseConnectionCard.tsx
  • frontend/web/components/pages/environment-settings/tabs/warehouse-tab/WarehouseSetup.tsx

📝 Walkthrough

Walkthrough

Adds stable HTML id attributes to experiment metric controls, wizard navigation and review actions, rollout controls, and warehouse settings buttons. The wizard derives button identifiers from step slugs while preserving existing disabled states and handlers. Warehouse connection markup adds identifiers for edit, delete, test, and enable actions without changing the surrounding conditional behaviour.

Estimated code review effort: 2 (Simple) | ~10 minutes


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  45.7 seconds
commit  cb05e10
info  🔄 Run: #18194 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 2 suites
duration  22.1 seconds
commit  cb05e10
info  🔄 Run: #18194 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  6 passed

Details

stats  6 tests across 5 suites
duration  17.5 seconds
commit  cb05e10
info  🔄 Run: #18194 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  7 passed

Details

stats  7 tests across 6 suites
duration  54.5 seconds
commit  cb05e10
info  🔄 Run: #18194 (attempt 1)

@github-actions

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@Zaimwa9 Zaimwa9 merged commit d479a3d into main Jul 14, 2026
30 checks passed
@Zaimwa9 Zaimwa9 deleted the feat/add-ids-to-experimentation-ctas branch July 14, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants