feat(experiments): attach a primary metric in the create experiment wizard by Zaimwa9 · Pull Request #7780 · Flagsmith/flagsmith

Zaimwa9 · 2026-06-15T09:42:27Z

Thanks for submitting a PR! Please check the boxes below:

I have read the Contributing Guide.
I have added information to docs/ if required so people know about the feature.
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.

Changes

Wires up the Measurement step of the Create Experiment wizard so a primary metric can be attached when creating an experiment.

Select one existing metric (paginated list of 5 + search), or create a new metric inline via a centred modal without leaving the wizard.
Pick the expected direction, prefilled from the metric's own direction.
The metric is required to launch; it's sent inline in the create payload (backend support landed in feat(experimentation): accept inline metrics on experiment creation #7770).
Review step summarises the attached metric and chosen direction, and the experiments list shows the attached primary metric.

How did you test this code?

Manually, against a local API + warehouse:

Open Experiments → Create experiment, complete Setup.
On Measurement, search/select a metric (add >5 to see paging), confirm the Primary badge and direction prefill.
Use Create Metric to add one inline; confirm it auto-selects.
Launch and verify the experiment is created with the metric attached, and that it appears in the experiments list's Primary Metric column.
Confirm launch is blocked until a metric + direction are chosen.

Plus npm run typecheck and eslint on the touched files.

vercel · 2026-06-15T09:42:34Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
flagsmith-frontend-preview	Ready	Preview, Comment	Jun 15, 2026 11:57am
flagsmith-frontend-staging	Ready	Preview, Comment	Jun 15, 2026 11:57am

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Ignored	Preview	Jun 15, 2026 11:57am

github-actions · 2026-06-15T09:43:39Z

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-api-test:pr-7780`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-e2e:pr-7780`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-api:pr-7780`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-7780`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-7780`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-frontend:pr-7780`	Finished ✅	Results ✅

github-actions · 2026-06-15T09:49:24Z

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
33.1 seconds
483b171
🔄 Run: #17490 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

19 passed

Details

19 tests across 15 suites
1 minute, 9 seconds
483b171
🔄 Run: #17490 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
44.1 seconds
483b171
🔄 Run: #17490 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
55.1 seconds
483b171
🔄 Run: #17490 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
32.9 seconds
ccdbdd3
🔄 Run: #17493 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
44.1 seconds
ccdbdd3
🔄 Run: #17493 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
1 minute, 13 seconds
ccdbdd3
🔄 Run: #17493 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
54.7 seconds
ccdbdd3
🔄 Run: #17493 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
32.9 seconds
1a41e93
🔄 Run: #17495 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
45.1 seconds
1a41e93
🔄 Run: #17495 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

2 passed

Details

2 tests across 2 suites
45.7 seconds
1a41e93
🔄 Run: #17495 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
43.5 seconds
1a41e93
🔄 Run: #17495 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
33.9 seconds
0a4b592
🔄 Run: #17497 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
43.1 seconds
0a4b592
🔄 Run: #17497 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

3 passed

Details

3 tests across 3 suites
35.6 seconds
0a4b592
🔄 Run: #17497 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
1 minute, 8 seconds
0a4b592
🔄 Run: #17497 (attempt 1)

github-actions · 2026-06-15T09:51:36Z

Visual Regression

19 screenshots compared. See report for details.
View full report

Zaimwa9 · 2026-06-15T11:15:51Z

@gemini-code-assist review

gemini-code-assist

Code Review

This pull request introduces a new CenteredModal component, enhances SelectableCard and ContentCard with additional layout options, and integrates a measurement step into the experiment creation wizard to allow selecting a primary metric and its expected direction. It also optimizes warehouse connection queries by adding an option to exclude event stats and prevents selecting feature flags already associated with active experiments. The review feedback highlights critical issues, including a mismatch in cache keys during pessimistic updates, a loading state (isEnabling) that gets stuck on successful warehouse connection creation, a hardcoded page size limit of 100 when checking for active experiments, and a potential runtime crash due to a missing defensive check on experiment.feature.

gemini-code-assist · 2026-06-15T11:17:57Z

+  const { data: experimentsData } = useGetExperimentsQuery(
+    { environmentId, page: 1, page_size: 100 },
+    { skip: !environmentId },
+  )


The query for experiments is hardcoded with page_size: 100. If an environment has more than 100 experiments, active experiments beyond the first page will be excluded from the results, allowing users to select a feature flag that is already associated with an active experiment. Consider fetching all active experiments or implementing this validation on the backend.

true but theoritcal, for now deferred

Zaimwa9 · 2026-06-15T11:37:52Z

@gemini-code-assist review

gemini-code-assist

Code Review

This pull request introduces the ability to select a primary metric and define its expected direction during the experiment creation wizard. It also adds a reusable CenteredModal component, updates UI cards (SelectableCard and ContentCard) to support tags and descriptions, and prevents users from selecting feature flags that are already associated with active experiments. The review feedback highlights three key issues: the need to validate the final Review step in the wizard to disable the launch button when previous steps are invalid, fixing a state desynchronization issue when clearing the expected direction dropdown, and increasing the hardcoded page size when querying existing experiments to avoid missing active flags.

Zaimwa9 added 11 commits June 12, 2026 15:02

feat: accept-inline-metrics-on-experiment-create

846e4b0

feat: add exclude_event_stats param to warehouse connections list

d9e4669

feat: experiment wizard primary metric selection

9d2ed50

feat: centered modal storybook story

0f51001

fix: warehouse enable loading and instant connection display

49536cd

fix: experiment wizard metric cards and review styling per design

949c0ad

fix: avoid warehouse stats query on experiments and metrics pages

c70218a

fix: disable flags already in an active experiment in wizard dropdown

a34fa4e

fix: metrics banner yellow text from Bootstrap text-secondary collision

1a7e4b8

feat: shrink 0 on table icons

09dcb7f

feat: rebased main

483b171

Zaimwa9 requested a review from a team as a code owner June 15, 2026 09:42

Zaimwa9 requested review from gagantrivedi and talissoncosta and removed request for a team June 15, 2026 09:42

flagsmith-engineering Bot assigned talissoncosta Jun 15, 2026

github-actions Bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Jun 15, 2026

feat: show primary metrics in experiment list view

ccdbdd3

vercel Bot deployed to Preview – flagsmith-frontend-staging June 15, 2026 11:16 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-preview June 15, 2026 11:16 View deployment

github-actions Bot added feature New feature or request and removed feature New feature or request labels Jun 15, 2026

gemini-code-assist Bot reviewed Jun 15, 2026

View reviewed changes

feat: instantly fetch successfully connected warehouse

1a41e93

vercel Bot deployed to Preview – flagsmith-frontend-preview June 15, 2026 11:38 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-staging June 15, 2026 11:38 View deployment

github-actions Bot added feature New feature or request and removed feature New feature or request labels Jun 15, 2026

gemini-code-assist Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread frontend/web/components/experiments/CreateExperimentWizard.tsx

Comment thread frontend/web/components/experiments/steps/MeasurementStep.tsx

Comment thread frontend/web/components/experiments/steps/SetupStep.tsx

feat: experiment wizard review feedback and warehouse enabling state

0a4b592

vercel Bot deployed to Preview – flagsmith-frontend-preview June 15, 2026 11:57 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-staging June 15, 2026 11:57 View deployment

github-actions Bot added feature New feature or request and removed feature New feature or request labels Jun 15, 2026

Conversation

Zaimwa9 commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

How did you test this code?

Uh oh!

vercel Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docker builds report

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual Regression

Uh oh!

Zaimwa9 commented Jun 15, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

Zaimwa9 Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Zaimwa9 commented Jun 15, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Zaimwa9 commented Jun 15, 2026 •

edited

Loading

vercel Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

Zaimwa9 Jun 15, 2026 •

edited

Loading