fix(frontend): keep dev-server overlay to compile errors only#7777
Open
talissoncosta wants to merge 1 commit into
Open
fix(frontend): keep dev-server overlay to compile errors only#7777talissoncosta wants to merge 1 commit into
talissoncosta wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
The overlay iframe intercepts all pointer events, so warnings (the Sass @import deprecation fires on every compile) and runtime errors hijacked the screen, blocking the app and any E2E run against the dev server. Restrict the overlay to compile errors and silence the non-actionable Sass @import deprecation; warnings still reach the terminal and browser console. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
talissoncosta
force-pushed
the
fix/dev-server-overlay
branch
from
b6503b7 to
981bf7e
Compare
github-actions
Bot
added
the
front-end
Contributor
Docker builds report
|
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
Contributor
Visual Regression19 screenshots compared. See report for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
In local dev (
ENV=local npm run dev), the rspack dev-server overlay renders a full-screen iframe that intercepts all pointer events. Two things trigger it constantly:@importdeprecation warning, which fires on every compile (the@use/@forwardmigration is a separate effort), anddata.*Response rejections.Both hijack the screen and block the app — and any E2E run pointed at the dev server. This keeps the overlay for compile errors (where it's genuinely useful), turns it off for warnings and runtime errors, and silences the non-actionable Sass
@importdeprecation. Warnings still appear in the terminal and browser console.How did you test this code?
Manually:
ENV=local npm run dev, confirmed the app loads and stays interactive with Sass deprecation warnings present and after a runtime rejection; compile errors still show the overlay.