fix(GitLab): issue/MR status in the feature Links panel goes stale after state changes#7545
fix(GitLab): issue/MR status in the feature Links panel goes stale after state changes#7545emyller wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7545 +/- ##
========================================
Coverage 98.47% 98.47%
========================================
Files 1400 1402 +2
Lines 53034 53157 +123
========================================
+ Hits 52224 52347 +123
Misses 810 810 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
khvn26
left a comment
There was a problem hiding this comment.
Looks great — just one comment.
| resource.metadata = json.dumps(merged) | ||
| resource.save(update_fields=["metadata"]) | ||
| log.info( | ||
| "external_resource.metadata.refreshed", |
There was a problem hiding this comment.
gitlab.external_resource.metadata.refreshed reads a bit noisy.
| "external_resource.metadata.refreshed", | |
| "feature.metadata.updated", |
Alternatively, since we're doing both tag and metadata updates in one sitting, consider consolidating the log at the gitlab_webhook level with an event like webhook.processed.
Thanks for submitting a PR! Please check the boxes below:
I have added information todocs/if required so people know about the feature.Changes
Closes #7370
Synchronises GitLab issue and merge request metadata (title and status) to Flagsmith when they're updated in GitLab.
How did you test this code?
New tests, and manual webhook-ngrok verification.