Skip to content

fix(GitLab): issue/MR status in the feature Links panel goes stale after state changes#7545

Open
emyller wants to merge 2 commits into
mainfrom
fix/gitlab-status-not-coming-back
Open

fix(GitLab): issue/MR status in the feature Links panel goes stale after state changes#7545
emyller wants to merge 2 commits into
mainfrom
fix/gitlab-status-not-coming-back

Conversation

@emyller
Copy link
Copy Markdown
Contributor

@emyller emyller commented May 19, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Closes #7370

Synchronises GitLab issue and merge request metadata (title and status) to Flagsmith when they're updated in GitLab.

How did you test this code?

New tests, and manual webhook-ngrok verification.

@emyller emyller self-assigned this May 19, 2026
@emyller emyller requested review from a team as code owners May 19, 2026 19:59
@emyller emyller requested review from khvn26 and removed request for a team May 19, 2026 19:59
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment May 19, 2026 7:59pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ignored Ignored May 19, 2026 7:59pm
flagsmith-frontend-staging Ignored Ignored May 19, 2026 7:59pm

Request Review

@github-actions github-actions Bot added api Issue related to the REST API docs Documentation updates fix and removed docs Documentation updates labels May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7545 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7545 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7545 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7545 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7545 Finished ✅ Results

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.47%. Comparing base (24f4d1a) to head (3266b2d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #7545    +/-   ##
========================================
  Coverage   98.47%   98.47%            
========================================
  Files        1400     1402     +2     
  Lines       53034    53157   +123     
========================================
+ Hits        52224    52347   +123     
  Misses        810      810            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  35.4 seconds
commit  3266b2d
info  🔄 Run: #16838 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  36.2 seconds
commit  3266b2d
info  🔄 Run: #16838 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  51.3 seconds
commit  3266b2d
info  🔄 Run: #16838 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  19 passed

Details

stats  19 tests across 15 suites
duration  1 minute, 45 seconds
commit  3266b2d
info  🔄 Run: #16838 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

Copy link
Copy Markdown
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great — just one comment.

resource.metadata = json.dumps(merged)
resource.save(update_fields=["metadata"])
log.info(
"external_resource.metadata.refreshed",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitlab.external_resource.metadata.refreshed reads a bit noisy.

Suggested change
"external_resource.metadata.refreshed",
"feature.metadata.updated",

Alternatively, since we're doing both tag and metadata updates in one sitting, consider consolidating the log at the gitlab_webhook level with an event like webhook.processed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitLab issue/MR status in the feature Links panel goes stale after state changes

2 participants