chore(API): Ignore egg-info packaging metadata#7539
Conversation
Editable installs from `make install-packages` generate `api/flagsmith_api.egg-info/`, which the `api-run-makefile-target` workflow then sweeps into auto-generated PRs (e.g. #7533). Ignore it so future runs only commit the intended diff. beep boop
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7539 +/- ##
==========================================
+ Coverage 98.39% 98.47% +0.07%
==========================================
Files 1400 1400
Lines 52892 53032 +140
==========================================
+ Hits 52044 52222 +178
+ Misses 848 810 -38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
|
Visual Regression16 screenshots compared. See report for details. |
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Editable installs run by
make install-packagesgenerateapi/flagsmith_api.egg-info/. Because the directory wasn't gitignored, theapi-run-makefile-targetworkflow was sweeping packaging metadata into auto-generated PRs alongside the intended change — see #7533 for the most recent example, where 2,000+ lines ofPKG-INFO/SOURCES.txt/etc. ride along with a one-line SDK version bump.Add
*.egg-info/toapi/.gitignoreso future runs only commit the intended diff.How did you test this code?
git check-ignore -v api/flagsmith_api.egg-info/PKG-INFOresolves to the new rule.