Skip to content

chore(API): Ignore egg-info packaging metadata#7539

Merged
khvn26 merged 1 commit into
mainfrom
chore/gitignore-egg-info
May 19, 2026
Merged

chore(API): Ignore egg-info packaging metadata#7539
khvn26 merged 1 commit into
mainfrom
chore/gitignore-egg-info

Conversation

@khvn26
Copy link
Copy Markdown
Member

@khvn26 khvn26 commented May 19, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Editable installs run by make install-packages generate api/flagsmith_api.egg-info/. Because the directory wasn't gitignored, the api-run-makefile-target workflow was sweeping packaging metadata into auto-generated PRs alongside the intended change — see #7533 for the most recent example, where 2,000+ lines of PKG-INFO/SOURCES.txt/etc. ride along with a one-line SDK version bump.

Add *.egg-info/ to api/.gitignore so future runs only commit the intended diff.

How did you test this code?

  • git check-ignore -v api/flagsmith_api.egg-info/PKG-INFO resolves to the new rule.
  • Existing PR chore: Track flagsmith-flutter-sdk 6.1.1 #7533 will need a rebase (or re-run of the workflow after this lands) to drop the already-committed files.

Editable installs from `make install-packages` generate
`api/flagsmith_api.egg-info/`, which the
`api-run-makefile-target` workflow then sweeps into
auto-generated PRs (e.g. #7533). Ignore it so future
runs only commit the intended diff.

beep boop
@khvn26 khvn26 requested a review from a team as a code owner May 19, 2026 09:37
@khvn26 khvn26 requested review from emyller and removed request for a team May 19, 2026 09:37
@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Building Building Preview, Comment May 19, 2026 9:37am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview May 19, 2026 9:37am
flagsmith-frontend-staging Ignored Ignored Preview May 19, 2026 9:37am

Request Review

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions github-actions Bot added api Issue related to the REST API chore labels May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7539 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7539 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api-test:pr-7539 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7539 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7539 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-7539 Finished ✅ Results

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.47%. Comparing base (a3dfe7c) to head (14295e9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7539      +/-   ##
==========================================
+ Coverage   98.39%   98.47%   +0.07%     
==========================================
  Files        1400     1400              
  Lines       52892    53032     +140     
==========================================
+ Hits        52044    52222     +178     
+ Misses        848      810      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  33.1 seconds
commit  14295e9
info  🔄 Run: #16815 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  41.8 seconds
commit  14295e9
info  🔄 Run: #16815 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  33.8 seconds
commit  14295e9
info  🔄 Run: #16815 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  35.9 seconds
commit  14295e9
info  🔄 Run: #16815 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression

16 screenshots compared. See report for details.
View full report

@khvn26 khvn26 merged commit d97ef5d into main May 19, 2026
31 of 36 checks passed
@khvn26 khvn26 deleted the chore/gitignore-egg-info branch May 19, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants