docs: restructure identities page; add PII rule and trait passing guidance#7525
Open
Holmus wants to merge 1 commit into
Open
docs: restructure identities page; add PII rule and trait passing guidance#7525Holmus wants to merge 1 commit into
Holmus wants to merge 1 commit into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
…dance Reorganises docs/flagsmith-concepts/identities.md so the persistent vs transient choice is a deliberate framing based on the nature of the data, rather than a privacy-edge-case footnote. Folds the existing storage / data-store / transient stubs into a single coherent section. New guidance: - PII rule: PII must be transient, including the identifier itself (use UUID / hashed ID, not email or username). Unifying principle: no PII in Flagsmith, anywhere. - Cross-service trait sharing: persistent traits let an identity carry trait data the evaluating service does not have direct access to (pre-associate via the admin API, or set from a separate service). - Passing traits at evaluation time: always pass the complete set of traits available. For persistent traits the value replaces the stored one; for transient traits passing is mandatory. Also moves Trait Value Data Types ahead of the storage section so traits are fully described before persistence is discussed, and removes the now-redundant Traits Powering Segments one-liner. Anchors preserved: #transient-traits (inbound link from segments/index.md still resolves) and a new #pii anchor. Closes #6824. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Holmus
force-pushed
the
docs/trait-nature-and-pii
branch
from
349e8b5 to
4ac2582
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restructures
docs/flagsmith-concepts/identities.mdso the persistent vs transient distinction is presented as a deliberate choice based on the nature of the data, rather than buried as a privacy-edge-case at the bottom of the page. Folds the existing storage / data-store / transient stubs into a single coherent section and adds three pieces of new guidance:Also moves
Trait Value Data Typesahead of the storage section so traits are fully described before persistence is discussed, and removes the now-redundantTraits Powering Segmentsone-liner (already covered in the intro).Anchors preserved:
#transient-traits(inbound link fromsegments/index.mdstill resolves) and a new#piianchor.Closes #6824.
Test plan
docusaurus buildpasses without new broken-anchor warningssegments/index.md#use-transient-traits-for-multi-tenancytoidentities#transient-traitsstill resolves🤖 Generated with Claude Code