Fix:Align Core API feature_segment shape with Edge API#7523
Open
SahilJat wants to merge 1 commit into
Open
Conversation
|
@SahilJat is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
5dce6c5 to
27f5ba9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7523 +/- ##
==========================================
- Coverage 98.47% 98.31% -0.16%
==========================================
Files 1400 1400
Lines 52980 52873 -107
==========================================
- Hits 52170 51981 -189
- Misses 810 892 +82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #7456
serialization of the priority field for feature segments.
the feature_segment field.
any other endpoints using FeatureStateSerializerFull) return the
same data shape as the Edge API, providing the priority information
that was previously missing.
How did you test this code?
Automated Tests: Added a new unit test in
api/tests/unit/environments/identities/test_unit_identities_views.pythat specifically sets up a segment override with a defined priorityand asserts that the /api/v1/identities/ response contains the
feature_segment as an object: {"priority": 1}.
ensure the change correctly propagates to the SDK identities and flags
endpoints while minimizing impact on write operations (as the field is
marked as read_only=True in the "Full" serializer).