Fix/replace axios with fetch slack#7521
Open
SahilJat wants to merge 1 commit into
Open
Conversation
|
@SahilJat is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
a2b220b to
2d3a25b
Compare
Contributor
Author
|
The Django migration failure (relation "app_analytics_analyticsmodel" already exists) in the Python test is a pre-existing flaky CI issue unrelated to this PR. This PR only touches api/slack-client.js, e2e/slack-e2e-reporter.ts, and package.json (frontend/Node files). No Python/Django code was modified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #7431
Replace @slack/web-api with native fetch calls to eliminate transitive Axios dependency which triggered multiple critical/high CVEs.
1)Rewrote api/slack-client.js to use fetch directly instead of WebClient.chat.postMessage
2)Rewrote e2e/slack-e2e-reporter.ts to replace postMessage and files.uploadV2 with direct Slack API calls (3-step upload flow: get upload URL → upload bytes → complete upload)
3)Removed axios override from package.json overrides block
No functional behaviour changes — all Slack messaging and file upload behaviour is preserved.
How did you test this code?
1)Confirmed package.json no longer contains the axios override
2)The existing E2E pipeline will exercise slack-e2e-reporter.ts naturally on the next test run with failures
3)api/slack-client.js can be smoke tested by triggering a Slack message in a dev/staging environment with SLACK_TOKEN set