Skip to content

chore: Use SAML from flagsmith-private#7515

Draft
matthewelwell wants to merge 1 commit into
mainfrom
feat/use-saml-from-flagsmith-private
Draft

chore: Use SAML from flagsmith-private#7515
matthewelwell wants to merge 1 commit into
mainfrom
feat/use-saml-from-flagsmith-private

Conversation

@matthewelwell
Copy link
Copy Markdown
Contributor

@matthewelwell matthewelwell commented May 14, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Replaces SAML import from #flagsmith/flagsmith-saml repository with flagsmith-private, pointing specifically to the branch associated with this PR.

How did you test this code?

  • Run the flagsmith-private-cloud docker image built as part of this PR and perform a smoke test of SAML functionality

@matthewelwell matthewelwell requested a review from a team as a code owner May 14, 2026 13:27
@matthewelwell matthewelwell requested review from emyller and removed request for a team May 14, 2026 13:27
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored May 14, 2026 1:27pm
flagsmith-frontend-preview Ignored Ignored May 14, 2026 1:27pm
flagsmith-frontend-staging Ignored Ignored May 14, 2026 1:27pm

Request Review

@github-actions github-actions Bot added api Issue related to the REST API feature New feature or request labels May 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7515 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7515 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api-test:pr-7515 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-7515 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-7515 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7515 Finished ✅ Results

Comment thread api/pyproject.toml
Comment on lines +179 to +180
# TODO: pin to tag once merged (and tagged)
flagsmith-private = { git = "https://github.com/Flagsmith/flagsmith-private", branch = "feat/import-saml" }
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double todo!

@matthewelwell matthewelwell marked this pull request as draft May 14, 2026 13:31
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.46%. Comparing base (70f25fa) to head (5857512).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7515   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files        1398     1398           
  Lines       52900    52900           
=======================================
  Hits        52090    52090           
  Misses        810      810           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  37.7 seconds
commit  5857512
info  🔄 Run: #16746 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  35.6 seconds
commit  5857512
info  🔄 Run: #16746 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  32.6 seconds
commit  5857512
info  🔄 Run: #16746 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  36.7 seconds
commit  5857512
info  🔄 Run: #16746 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression

16 screenshots compared. See report for details.
View full report

@khvn26 khvn26 changed the title feat: Use SAML from flagsmith-private chore: Use SAML from flagsmith-private May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant