chore: Use SAML from flagsmith-private#7515
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Docker builds report
|
| # TODO: pin to tag once merged (and tagged) | ||
| flagsmith-private = { git = "https://github.com/Flagsmith/flagsmith-private", branch = "feat/import-saml" } |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7515 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 1398 1398
Lines 52900 52900
=======================================
Hits 52090 52090
Misses 810 810 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
|
Visual Regression16 screenshots compared. See report for details. |
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Replaces SAML import from #flagsmith/flagsmith-saml repository with flagsmith-private, pointing specifically to the branch associated with this PR.
How did you test this code?
flagsmith-private-clouddocker image built as part of this PR and perform a smoke test of SAML functionality