Skip to content

ci: Add flagsmith-lint-tests pre-commit hook#6933

Open
khvn26 wants to merge 2 commits intomainfrom
test/flagsmith-lint-tests-hook
Open

ci: Add flagsmith-lint-tests pre-commit hook#6933
khvn26 wants to merge 2 commits intomainfrom
test/flagsmith-lint-tests-hook

Conversation

@khvn26
Copy link
Member

@khvn26 khvn26 commented Mar 12, 2026

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

  • Add flagsmith-lint-tests pre-commit hook from flagsmith-common (fv3.4.0)
  • Add # noqa comments to all existing violations (2052 FT003, 341 FT004)

How did you test this code?

pre-commit run flagsmith-lint-tests --all-files passes.

@vercel
Copy link

vercel bot commented Mar 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Mar 12, 2026 6:10pm
flagsmith-frontend-preview Ignored Ignored Preview Mar 12, 2026 6:10pm
flagsmith-frontend-staging Ignored Ignored Preview Mar 12, 2026 6:10pm

Request Review

@github-actions github-actions bot added api Issue related to the REST API testing labels Mar 12, 2026
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.31%. Comparing base (dbd66e9) to head (d3c94e4).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6933   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files        1335     1335           
  Lines       49717    49717           
=======================================
  Hits        48879    48879           
  Misses        838      838           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khvn26 khvn26 changed the title test: Add flagsmith-lint-tests pre-commit hook ci: Add flagsmith-lint-tests pre-commit hook Mar 12, 2026
Add the flagsmith-lint-tests pre-commit hook from flagsmith-common
(fv3.4.0) and add # noqa comments to all existing test violations.
@github-actions github-actions bot added testing and removed testing labels Mar 12, 2026
@khvn26 khvn26 force-pushed the test/flagsmith-lint-tests-hook branch from 32b2092 to d3c94e4 Compare March 12, 2026 18:10
@khvn26 khvn26 marked this pull request as ready for review March 12, 2026 18:10
@khvn26 khvn26 requested review from a team as code owners March 12, 2026 18:10
@khvn26 khvn26 requested review from gagantrivedi and removed request for a team March 12, 2026 18:10
@khvn26 khvn26 changed the title ci: Add flagsmith-lint-tests pre-commit hook chore: Add flagsmith-lint-tests pre-commit hook Mar 12, 2026
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed testing ci-cd Build, test and deployment related labels Mar 12, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-6933 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-6933 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api-test:pr-6933 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6933 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6933 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6933 Finished ✅ Results

@khvn26 khvn26 changed the title chore: Add flagsmith-lint-tests pre-commit hook ci: Add flagsmith-lint-tests pre-commit hook Mar 12, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  49.4 seconds
commit  d3c94e4
info  🔄 Run: #15271 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  25.5 seconds
commit  d3c94e4
info  🔄 Run: #15271 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  54 seconds
commit  d3c94e4
info  🔄 Run: #15271 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute, 3 seconds
commit  d3c94e4
info  🔄 Run: #15271 (attempt 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API ci-cd Build, test and deployment related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant