Conversation
Zaimwa9
force-pushed
the
feat/experiment-metadata
branch
from
September 15, 2026 17:11
47926aa to
4c8e1e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Core now sends
metadata.experiment { id, name, in_experiment }on/identitiesflags while the feature's experiment is running (Flagsmith/flagsmith#8532).Flag.experiment: Optional[ExperimentMetadata], a frozen dataclass populated inFlag.from_api_flag.Noneon older servers and in local evaluation.get_experiment_flagfires the exposure only whenexperiment.in_experimentis true, instead of guessing fromvariant.experiment_idfor attribution.How did you test this code?
pytest: 128 passing, new cases in
tests/test_models.pyandtests/test_flagsmith.py.pre-commit clean.
Manual QA against staging once Core and Edge are deployed.