Skip to content

fix(Segments): Standardise regex matching in the PHP server-side SDK #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linear-code wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(Segments): Standardise regex matching in the PHP server-side SDK #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Engine/Engine.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ private static function _contextMatchesCondition(
&& !str_contains($contextValue, $condition->value);

case SegmentConditionOperator::REGEX:
return (bool) preg_match("/{$condition->value}/", (string) $contextValue);
return (bool) preg_match("/{$condition->value}/A", (string) $contextValue); // A: anchored at start, not full match
}

if ($contextValue === null) {
Expand Down
73 changes: 73 additions & 0 deletions tests/Engine/Unit/Segments/RegexConditionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
<?php

namespace FlagsmithTest\Engine\Unit\Segments;

use Flagsmith\Engine\Engine;
use Flagsmith\Engine\Utils\Types\Context\EvaluationContext;
use PHPUnit\Framework\TestCase;

class RegexConditionTest extends TestCase
{
/** @return array<string, array{string, string, bool}> */
public function traitValuesAndPatterns(): array
{
return [
'value starting with the pattern' => ['production', 'prod', true],
'pattern found only mid-value' => ['nonproduction', 'prod', false],
'value starting with any alternative' => ['development', 'prod|dev', true],
'alternative found only mid-value' => ['nondev', 'prod|dev', false],
'end-anchored pattern found only mid-value' => ['jane@example.com', '@example\.com$', false],
'fully anchored email domain' => ['jane@example.com', '^[^@]+@example\.com$', true],
'fully anchored environment prefix' => ['prod-api', '^(prod|uat|dev)-.+$', true],
'fully anchored fixed-format ID' => ['user-0001', '^user-[0-9]{4}$', true],
'fully anchored ID with trailing characters' => ['user-00012', '^user-[0-9]{4}$', false],
'value differing in case' => ['Production', 'prod', false],
'numeric trait value' => ['123', '^\d+$', true],
];
}

/**
* @dataProvider traitValuesAndPatterns
*/
public function testIdentityIsInSegmentWhenTraitMatchesRegexFromTheStart(
string $traitValue,
string $pattern,
bool $expectedInSegment,
): void {
// Given
$context = EvaluationContext::fromJsonObject((object) [
'environment' => (object) ['key' => 'api-key', 'name' => 'Test'],
'identity' => (object) [
'identifier' => 'jane',
'traits' => (object) ['environment' => $traitValue],
],
'segments' => [
(object) [
'key' => '1',
'name' => 'regex_segment',
'rules' => [
(object) [
'type' => 'ALL',
'conditions' => [
(object) [
'property' => 'environment',
'operator' => 'REGEX',
'value' => $pattern,
],
],
],
],
],
],
]);

// When
$result = Engine::getEvaluationResult($context);

// Then
$this->assertSame(
$expectedInSegment ? ['regex_segment'] : [],
array_map(fn ($segment) => $segment->name, $result->segments),
);
}
}
Loading