Skip to content

fix(build): go install doesn't work as documented - #62

Merged
khvn26 merged 1 commit into
mainfrom
module-v2
Jul 30, 2026
Merged

fix(build): go install doesn't work as documented#62
khvn26 merged 1 commit into
mainfrom
module-v2

Conversation

@khvn26

@khvn26 khvn26 commented Jul 30, 2026

Copy link
Copy Markdown
Member

go install github.com/Flagsmith/flagsmith-cli@latest resolves v1.1.0 and fails. In go, major ≥2 requires the /v2 suffix.

  • module github.com/Flagsmith/flagsmith-cli/v2; imports rewritten, ldflags path updated
  • README pins the beta tag, since @latest skips prereleases while v1.1.0 exists; release-please keeps the pin current
  • go install names binaries after the module path, so it lands as flagsmith-cli

Verified: build, vet, test, go mod tidy -diff, all hooks, and a goreleaser snapshot still stamping the version — a stale ldflags path would silently print dev.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@khvn26, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 58c79253-7187-4da4-8d08-82e047182146

📥 Commits

Reviewing files that changed from the base of the PR and between 8608fb5 and 812b10d.

📒 Files selected for processing (35)
  • .goreleaser.yaml
  • README.md
  • go.mod
  • install.sh
  • internal/api/client.go
  • internal/auth/oauth.go
  • internal/auth/store.go
  • internal/cmd/api.go
  • internal/cmd/auth.go
  • internal/cmd/client.go
  • internal/cmd/cmd_test.go
  • internal/cmd/config.go
  • internal/cmd/context.go
  • internal/cmd/environment.go
  • internal/cmd/errors.go
  • internal/cmd/errors_test.go
  • internal/cmd/feature.go
  • internal/cmd/flag_identity.go
  • internal/cmd/flag_reorder.go
  • internal/cmd/flag_update.go
  • internal/cmd/flags.go
  • internal/cmd/init.go
  • internal/cmd/login.go
  • internal/cmd/logout.go
  • internal/cmd/organisation.go
  • internal/cmd/project.go
  • internal/cmd/prompts.go
  • internal/cmd/render.go
  • internal/cmd/resolve.go
  • internal/cmd/root.go
  • internal/cmd/segment.go
  • internal/cmd/sentinel_test.go
  • internal/version/version.go
  • main.go
  • release-please-config.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@khvn26 khvn26 changed the title build!: move the module to /v2 build!: move the module to /v2 Jul 30, 2026
@khvn26 khvn26 changed the title build!: move the module to /v2 build: move the module to /v2 Jul 30, 2026
@khvn26 khvn26 changed the title build: move the module to /v2 fix(build): go install doesn't work as documented Jul 30, 2026
@khvn26 khvn26 mentioned this pull request Jul 30, 2026
10 tasks
@khvn26
khvn26 marked this pull request as ready for review July 30, 2026 11:33
@khvn26
khvn26 requested a review from Zaimwa9 July 30, 2026 12:00

@Zaimwa9 Zaimwa9 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Zaimwa9
Zaimwa9 previously approved these changes Jul 30, 2026
auto-merge was automatically disabled July 30, 2026 12:40

Pull Request is not mergeable

auto-merge was automatically disabled July 30, 2026 12:45

Pull Request is not mergeable

@khvn26
khvn26 changed the base branch from install-ps1 to main July 30, 2026 13:20
@khvn26
khvn26 dismissed Zaimwa9’s stale review July 30, 2026 13:20

The base branch was changed.

`go install github.com/Flagsmith/flagsmith-cli@latest` resolves v1.1.0 — the
npm-era tag, which contains no Go code — and fails with "does not contain
package". Tagging v2 does not fix it: a module at major 2 or higher must carry
the matching path suffix, and the +incompatible escape applies only to repos
without a go.mod, so v2 tags would simply be invalid for the old path and
@latest would stay on v1.1.0 forever.

The suffix is unavoidable if we tag v2 at all; the alternatives were releasing
the rewrite on the v1 line or dropping `go install` from the docs.

The README pins the beta tag rather than using @latest, which skips prereleases
when any release exists — v1.1.0 does. release-please keeps the pin current
through extra-files, same as the two installers.

`go install` names the binary after the module path, so it lands as
flagsmith-cli; the README says so.

beep boop

@matthewelwell matthewelwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blindly stamping based on previous approval which was dismissed by a rebase 🙈

@khvn26
khvn26 merged commit 4dc43a8 into main Jul 30, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants