Skip to content

ci: build release binaries with goreleaser - #55

Merged
khvn26 merged 5 commits into
mainfrom
goreleaser-binaries
Jul 30, 2026
Merged

ci: build release binaries with goreleaser#55
khvn26 merged 5 commits into
mainfrom
goreleaser-binaries

Conversation

@khvn26

@khvn26 khvn26 commented Jul 29, 2026

Copy link
Copy Markdown
Member

Contributes to #45

Verified locally

  • goreleaser check clean.
  • goreleaser release --snapshot --clean --skip=publish built all six targets and packaged them; archives contain flagsmith, LICENSE, README.md.
  • The darwin/arm64 binary prints flagsmith version v1.1.0 — the stamp resolves through the internal/version.Version ldflags path.

Also attests the archives: actions/attest with subject-checksums covers every file listed in checksums.txt. Verify with gh attestation verify --owner Flagsmith <file>.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@khvn26, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ce33f28d-5217-4ba9-92d8-d713fc258815

📥 Commits

Reviewing files that changed from the base of the PR and between 090323e and ab10f29.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • .goreleaser.yaml
📝 Walkthrough

Walkthrough

Adds release-please metadata, GoReleaser configuration for cross-platform flagsmith binaries, archive formats, version injection, checksums, and release settings. Adds a GitHub Actions workflow triggered by v* tags that runs GoReleaser, attests checksum-listed artifacts, and updates beta release metadata.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@khvn26
khvn26 marked this pull request as ready for review July 29, 2026 10:49
@khvn26
khvn26 requested review from a team and emyller and removed request for a team July 29, 2026 12:28
@khvn26 khvn26 mentioned this pull request Jul 29, 2026
10 tasks
Zaimwa9
Zaimwa9 previously approved these changes Jul 30, 2026

@Zaimwa9 Zaimwa9 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a nit

Comment thread .github/workflows/release.yml
Base automatically changed from release-please-config to main July 30, 2026 10:36
@khvn26
khvn26 force-pushed the goreleaser-binaries branch from 513c2fc to 96727e9 Compare July 30, 2026 10:36

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 436b45fe-353f-4cf1-84eb-22912b846d74

📥 Commits

Reviewing files that changed from the base of the PR and between 7255b9d and 96727e9.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • .goreleaser.yaml

Comment thread .github/workflows/release.yml
Comment thread .goreleaser.yaml

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 666776f3-aed1-47c0-a64e-a52f4996628e

📥 Commits

Reviewing files that changed from the base of the PR and between 96727e9 and 090323e.

📒 Files selected for processing (4)
  • .github/workflows/release.yml
  • .goreleaser.yaml
  • .release-please-manifest.json
  • release-please-config.json

Comment thread .goreleaser.yaml Outdated
khvn26 added 5 commits July 30, 2026 13:10
Six targets, matching the cross-compile job: linux, darwin and windows on
amd64 and arm64. CGO_ENABLED=0 costs nothing — go-keyring shells out to
`security` on macOS and talks D-Bus on Linux, neither of which needs cgo.

The tag drives everything: release-please creates it and the release, then
`mode: append` uploads the archives into that release without touching the
notes it wrote.

beep boop
goreleaser has no attestation of its own — the documented route is
actions/attest after it runs. subject-checksums attests every file listed in
checksums.txt, so all six archives are covered without naming them.

Verify with `gh attestation verify --owner Flagsmith <file>`.

beep boop
GitHub will not let a prerelease be Latest ("Drafts and prereleases cannot be
set as latest"), and the prerelease flag is not separable from the -beta
version: release-please derives it from the version itself. So clear the flag
after publishing instead. The condition takes itself out of service once 2.0.0
ships, since a stable release becomes Latest on its own.

beep boop
`mode` governs the release notes, not the artifacts — those upload either way.
append happens to be harmless while the changelog is disabled, since our notes
are empty, but keep-existing says what we mean and stays correct if anyone
enables the changelog later.

beep boop
.Tag is the last release tag even under --snapshot, so every snapshot stamped
v1.1.0 and IsRelease then pinned doc URLs to a tag the build has nothing to do
with. Snapshots now stamp the snapshot version, v1.1.0-SNAPSHOT-090323e.

Stamping the literal `dev` would not have worked: resolve() treats dev as
unstamped and replaces it from debug.ReadBuildInfo, which yields a Go
pseudo-version — correct, but it would show up in --version and the User-Agent
as v1.1.1-0.20260730115333-090323eb8be5+dirty.

beep boop
@khvn26
khvn26 force-pushed the goreleaser-binaries branch from e0524b2 to ab10f29 Compare July 30, 2026 12:10
@khvn26
khvn26 merged commit 0647ea1 into main Jul 30, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants