Skip to content

Improve results display - #284

Open
matthieugomez wants to merge 2 commits into
FixedEffects:mainfrom
matthieugomez:improve-printing
Open

Improve results display#284
matthieugomez wants to merge 2 commits into
FixedEffects:mainfrom
matthieugomez:improve-printing

Conversation

@matthieugomez

@matthieugomez matthieugomez commented Aug 31, 2026

Copy link
Copy Markdown
Member

Closes #237.

  • Show the dependent variable first in the header
  • Mark IV models in the title (FixedEffectModel (IV))
  • Format the F-test p-value with PValue (<1e-99 instead of 0.000)
  • Add a thousands separator to the number of observations
  • Drop the Converged row (it was a row filler in the base block); print a warning line under the header instead when demeaning did not converge
  • Widen the table when a header label/value pair does not fit in half of it, instead of silently misaligning the row
  • Regenerate the README example with the new format
                            FixedEffectModel
=========================================================================
Dependent variable:           Sales   Number of obs:                1,380
dof (model):                      1   dof (residuals):                 45
R²:                           0.803   R² adjusted:                  0.791
F-statistic:                13.3382   P-value:                     0.0007
R² within:                    0.139   Iterations:                       5
=========================================================================
        Estimate  Std. Error    t-stat  Pr(>|t|)   Lower 95%    Upper 95%
─────────────────────────────────────────────────────────────────────────
NDI  -0.00526264  0.00144097  -3.65216    0.0007  -0.0081649  -0.00236038
=========================================================================

- Show dependent variable in the header (closes FixedEffects#237)
- Mark IV models in the title
- Format the F-test p-value like coefficient p-values
- Add thousands separator to number of obs
- Move Converged next to Iterations in the fixed-effect block
- Widen the table when a header pair does not fit in half of it
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@5edd010). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/FixedEffectModel.jl 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage        ?   97.87%           
=======================================
  Files           ?        8           
  Lines           ?      799           
  Branches        ?        0           
=======================================
  Hits            ?      782           
  Misses          ?       17           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Print name of dependent variable in FixedEffectModel results display?

1 participant