Make ServerTraceServices.start() plugins argument optional (regression from #68)#73
Merged
pcisar merged 1 commit intoMay 22, 2026
Conversation
FirebirdSQL#68 added a `plugins` keyword-only parameter to ServerTraceServices.start() but without a default value, making it required. This breaks every existing caller -- including this project's own tests/test_server.py::test_trace -- with: TypeError: ServerTraceServices.start() missing 1 required keyword-only argument: 'plugins' The method body already treats the argument as optional (`if plugins is not None:`) and its docstring documents it as FB6+ only, so restore the `= None` default. Adds a regression test asserting the parameter keeps a default of None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ServerTraceServices.start()cannot be called the way it always has been:raises:
This breaks every existing caller, including this repository's own
tests/test_server.py::test_trace.Root cause
#68 added a
pluginskeyword-only parameter tostart(), but without adefault value, so it became required:
The method body already treats it as optional (
if plugins is not None:) andthe docstring documents it as "only for FIREBIRD 6+", so it was clearly
intended to be optional.
Fix
Restore the
= Nonedefault:Testing
Adds
test_trace_start_plugins_is_optional, a server-free regression testasserting
pluginskeeps a default ofNone. It fails onmasterand passeswith this change; the existing
test_traceintegration test also passes again.