Skip to content

Added default initialization to avoid garbage values #8973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3qupo wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Added default initialization to avoid garbage values #8973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
fd6857c
fix: initializing a variable of type FB_UINT64 with a null value
3qupo Aug 29, 2025
a6988a4
initializing a variable of type SINT64 with a null value
3qupo Aug 29, 2025
4e97b5c
changed the .ebb file, but the warning didn't go away
3qupo Sep 1, 2025
7ec3f4b
initializing a variable of type USHORT with a null value
3qupo Sep 1, 2025
a6db65e
initializing a pointer of type SLONG* nullptr
3qupo Sep 1, 2025
0fe3203
initializing a pointer of type UCHAR* nullptr
3qupo Sep 1, 2025
533aab5
initializing variables with zero and default value
3qupo Sep 1, 2025
64963c8
Delete skipfile.txt
3qupo Sep 4, 2025
bfa093b
the default value for trig_t has been added and initialized
3qupo Dec 13, 2025
f335f7c
the default value is 0 as there will be a recalculation
3qupo Dec 13, 2025
30810af
Merge branch 'master' into added_default_initialization_to_avoid_garb…
3qupo Mar 31, 2026
d84f8db
fix: initialize max_segment to USHRT_MAX for safe default
3qupo Apr 5, 2026
a2e9f22
fix: use fld_ranges as default for end_ranges initialization
3qupo Apr 5, 2026
cfcb213
refactor: move upper/lower declarations outside loops to avoid reinit…
3qupo Apr 5, 2026
f4c7ab2
fix: prevent undefined behavior by initializing usr, userSet and type…
3qupo Apr 5, 2026
7f2329f
fix: add check that trigger type was assigned a meaningful value
3qupo Apr 5, 2026
232b565
refactor: use proper TTypeId type for from_interp instead of generic …
3qupo Apr 5, 2026
d3d0952
revert: remove redundant type_found check as trig_none is caught by s…
3qupo Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/burp/burp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,7 @@ enum att_type {
// Trigger types

enum trig_t {
trig_none = 0,
trig_pre_store = 1, // default
trig_pre_modify, // default
trig_post_erase // default
Expand Down
19 changes: 11 additions & 8 deletions src/burp/restore.epp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include <stdio.h>
#include <string.h>
#include <errno.h>
#include <limits.h>
#ifdef HAVE_CTYPE_H
#include <ctype.h>
#endif
Expand Down Expand Up @@ -1608,7 +1609,7 @@ bool get_acl(BurpGlobals* tdgbl, const TEXT* owner_nm, ISC_QUAD* blob_id, ISC_QU

ULONG length = 0;
UCHAR item;
USHORT max_segment;
USHORT max_segment = USHRT_MAX;
ULONG num_segments;
const UCHAR* p = blob_info;

Expand Down Expand Up @@ -1783,7 +1784,7 @@ void get_array(BurpGlobals* tdgbl, burp_rel* relation, UCHAR* record_buffer)
SLONG fld_ranges[2 * MAX_DIMENSION];
SLONG slice_length = 0;
SLONG *range;
const SLONG* end_ranges;
const SLONG* end_ranges = fld_ranges;
scan_attr_t scan_next_attr;
skip_init(&scan_next_attr);
att_type attribute;
Expand Down Expand Up @@ -1851,7 +1852,6 @@ void get_array(BurpGlobals* tdgbl, burp_rel* relation, UCHAR* record_buffer)
SLONG last_element_dim[MAX_DIMENSION];
if (return_length != slice_length)
{
int upper, lower;
//
// Ugh! The full array wasn't returned and versions of gbak prior to
// V3.2I don't explicitly signal this. We must recompute the top
Expand Down Expand Up @@ -1974,6 +1974,8 @@ void get_array(BurpGlobals* tdgbl, burp_rel* relation, UCHAR* record_buffer)
// dims were (1,2), we would just do a isc_put_slice(1..1, 1..2).
// This is applied for any number of dimensions.
//

int upper = 0, lower = 0;
for (range = field->fld_ranges, count = 0; range < end_ranges; range += 2, count++)
{
add_byte(blr, isc_sdl_do2);
Expand Down Expand Up @@ -3386,7 +3388,7 @@ void get_data(BurpGlobals* tdgbl, burp_rel* relation, WriteRelationReq* req)
}
}

UCHAR* p;
UCHAR* p = nullptr;
if (tdgbl->gbl_sw_transportable)
{
if (get(tdgbl) != att_xdr_length)
Expand Down Expand Up @@ -9096,9 +9098,10 @@ bool get_db_creator(BurpGlobals* tdgbl)
**************************************/
att_type attribute;
scan_attr_t scan_next_attr;
TEXT usr[GDS_NAME_LEN];
SSHORT uType;
bool userSet, typeSet;
TEXT usr[GDS_NAME_LEN] = {0};
SSHORT uType = 0;
Copy link
Copy Markdown
Contributor

@aafemt aafemt Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointless because of initialization of typeSet below. But if your AI insist - initialize usr as well for symmetry.

bool userSet = false;
bool typeSet = false;

userSet = typeSet = false;

Expand Down Expand Up @@ -9422,7 +9425,7 @@ bool get_trigger_old (BurpGlobals* tdgbl, burp_rel* relation)
* Get a trigger definition for a relation.
*
**************************************/
enum trig_t type;
enum trig_t type = trig_none;
Copy link
Copy Markdown
Contributor

@aafemt aafemt Mar 31, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness you should also add a check that a meaningful value was assigned below and throw an error if type is still trig_none.

att_type attribute;
TEXT name[GDS_NAME_LEN];
scan_attr_t scan_next_attr;
Expand Down
3 changes: 2 additions & 1 deletion src/dsql/DdlNodes.epp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,8 @@ static void checkForeignKeyTempScope(thread_db* tdbb, jrd_tra* transaction,
{
AutoCacheRequest request(tdbb, drq_l_rel_info, DYN_REQUESTS);
QualifiedName masterRelName;
rel_t masterType, childType;
rel_t masterType = rel_persistent;
Copy link
Copy Markdown
Contributor

@aafemt aafemt Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is basically wrong and will fail in the case if the table has several foreign keys. It must be fixed, not polished.

rel_t childType = rel_persistent;

FOR(REQUEST_HANDLE request TRANSACTION_HANDLE transaction)
RLC_M IN RDB$RELATION_CONSTRAINTS CROSS
Expand Down
4 changes: 2 additions & 2 deletions src/jrd/cvt2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,7 +973,7 @@ USHORT CVT2_make_string2(const dsc* desc, TTypeId to_interp, UCHAR** address, Mo
**************************************/
UCHAR* from_buf;
USHORT from_len;
TTypeId from_interp;
TTypeId from_interp = ttype_none;

fb_assert(desc != NULL);
fb_assert(address != NULL);
Expand Down Expand Up @@ -1004,7 +1004,7 @@ USHORT CVT2_make_string2(const dsc* desc, TTypeId to_interp, UCHAR** address, Mo

if (desc->isText())
{
if (from_interp == to_interp || to_interp == ttype_none || to_interp == ttype_binary)
if (from_interp == ttype_none || from_interp == to_interp || to_interp == ttype_none || to_interp == ttype_binary)
Copy link
Copy Markdown
Contributor

@aafemt aafemt Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a wrong change: NONE is the most permissive charset, so conversion from NONE to something else requires validation of data which can be skipped in the other direction.

{
*address = from_buf;
return from_len;
Expand Down
2 changes: 1 addition & 1 deletion src/jrd/os/posix/unix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ bool PIO_header(thread_db* tdbb, UCHAR* address, unsigned length)
const auto dbb = tdbb->getDatabase();

unsigned i;
SINT64 bytes;
SINT64 bytes = 0;

PageSpace* const pageSpace = dbb->dbb_page_manager.findPageSpace(DB_PAGE_SPACE);
jrd_file* const file = pageSpace->file;
Expand Down
2 changes: 1 addition & 1 deletion src/remote/client/interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2011,7 +2011,7 @@ unsigned char* Attachment::getLocalInfo(UCharBuffer& info, unsigned int buffer_l
break;
}

FB_UINT64 value;
FB_UINT64 value = 0;
bool skip = false;

switch (*item)
Expand Down