Skip to content

Make builder do not unspool the domain list - #116

Merged
piquark6046 merged 2 commits into
mainfrom
feature/wildcard-domain-grouping
Nov 18, 2026
Merged

piquark6046 merged 2 commits into
mainfrom
feature/wildcard-domain-grouping

Conversation

@piquark6046

Copy link
Copy Markdown
Member

No description provided.

@piquark6046
piquark6046 marked this pull request as ready for review November 18, 2026 13:36
Copilot AI balanced review requested due to automatic review settings November 18, 2026 13:36
@piquark6046
piquark6046 merged commit df6cf6b into main Nov 18, 2026
10 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review reports no active issues with the concrete-domain matching changes.

No open issues 🎉

What changed in this PR

This PR stops the userscript builder from expanding wildcard suffixes into uncollected domains. It separates domain grouping from execution rules so generated scripts match only collected concrete domains.

Changes:

  • Preserve collected domains while maintaining deterministic groups and metadata mappings.
  • Remove wildcard-suffix expansion, skip wildcard-only groups, and reject banners without concrete domains.
  • Add regression tests and document matching and subscription behavior.
File Description
README.md Documents concrete-domain matching, group filenames, and metadata hashes.
README.ko.md Adds equivalent Korean matching and metadata guidance.
README.ja.md Documents concrete-domain matching in Japanese.
libs/​test/​references/​group-metadata.test.ts Tests metadata mappings and standard/grouped build output.
libs/​test/​references/​domain-views.test.ts Tests domain preservation, grouping, and input-order independence.
libs/​test/​references/​discard-resolved-dup-wildcard.test.ts Updates expectations to preserve unrelated concrete domains.
libs/​test/​references/​banner.test.ts Tests concrete-only match rules and empty-set rejection.
libs/​source/​references/​utils/​wildcard-suffix-converter.ts Removes suffix-list expansion.
libs/​source/​references/​utils/​regroup-domain-tldlevel.ts Exposes root-label lookup and removes suffix-list mutation.
libs/​source/​references/​utils/​discard-resolved-dup-wildcard.ts Refines wildcard deduplication and suffix-based normalization.
libs/​source/​references/​index.ts Introduces domain views linking normalized groups to collected domains.
builder/​source/​build-grouped.ts Uses explicit group mappings, skips wildcard-only groups, and cleans up workers.
builder/​source/​banner/​index.ts Emits matches only for concrete domains and rejects empty matching sets.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants