Repository navigation
Make builder do not unspool the domain list - #116
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The review reports no active issues with the concrete-domain matching changes.
No open issues 🎉
What changed in this PR
This PR stops the userscript builder from expanding wildcard suffixes into uncollected domains. It separates domain grouping from execution rules so generated scripts match only collected concrete domains.
Changes:
- Preserve collected domains while maintaining deterministic groups and metadata mappings.
- Remove wildcard-suffix expansion, skip wildcard-only groups, and reject banners without concrete domains.
- Add regression tests and document matching and subscription behavior.
| File | Description |
|---|---|
| README.md | Documents concrete-domain matching, group filenames, and metadata hashes. |
| README.ko.md | Adds equivalent Korean matching and metadata guidance. |
| README.ja.md | Documents concrete-domain matching in Japanese. |
| libs/test/references/group-metadata.test.ts | Tests metadata mappings and standard/grouped build output. |
| libs/test/references/domain-views.test.ts | Tests domain preservation, grouping, and input-order independence. |
| libs/test/references/discard-resolved-dup-wildcard.test.ts | Updates expectations to preserve unrelated concrete domains. |
| libs/test/references/banner.test.ts | Tests concrete-only match rules and empty-set rejection. |
| libs/source/references/utils/wildcard-suffix-converter.ts | Removes suffix-list expansion. |
| libs/source/references/utils/regroup-domain-tldlevel.ts | Exposes root-label lookup and removes suffix-list mutation. |
| libs/source/references/utils/discard-resolved-dup-wildcard.ts | Refines wildcard deduplication and suffix-based normalization. |
| libs/source/references/index.ts | Introduces domain views linking normalized groups to collected domains. |
| builder/source/build-grouped.ts | Uses explicit group mappings, skips wildcard-only groups, and cleans up workers. |
| builder/source/banner/index.ts | Emits matches only for concrete domains and rejects empty matching sets. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.