internal/witness: use uint8 origin lengths in add-entries - #73
Merged
FiloSottile merged 1 commit intoOct 1, 2026
Merged
Conversation
Co-authored-by: Shelley <shelley@exe.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the tlog-mirror wire-format change from C2SP/C2SP#357: read the add-entries origin length as a uint8 instead of a big-endian uint16. Ticket and entry lengths remain uint16.
Update the test request encoders and header offsets, and cover successful uploads with 1-byte and 255-byte origins (including multibyte UTF-8), plus rejection of the old uint16 origin prefix. Existing malformed-request tests cover empty origins and truncation throughout the header.
The companion tlog-checkpoint parser limit belongs in Torchwood: Sunlight delegates checkpoint parsing to
torchwood.ParseCheckpoint, and the current v0.10.0 dependency does not enforce the new 255-byte limit. This PR leaves that dependency follow-up separate rather than duplicating its parser locally.Validation:
go test ./...go test -race ./internal/witnessgit diff --checkCompanion parser validation PR: FiloSottile/torchwood#96.