Skip to content

feat: Remove synapse-sdk dependency, --notest becomes the norm, cleanup unused scripts. #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redpanda-f merged 5 commits into from
Mar 2, 2026
+303 −799
Merged

feat: Remove synapse-sdk dependency, --notest becomes the norm, cleanup unused scripts. #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84823b8
feat(synapse-test): use cast-based client setup and devnet-info.json …
rvagg Feb 28, 2026
7f501f8
remove: scripts, that are vestiges of elden times
redpanda-f Mar 2, 2026
e7f9ee8
remove: synapse-sdk, e2e step, notest becomes norm
redpanda-f Mar 2, 2026
913aa8f
makehappy: fmt
redpanda-f Mar 2, 2026
fe47512
rename: CI test
redpanda-f Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Run clippy
run: cargo clippy --all-targets --all-features -- -D warnings

integration-test:
foc-start-test:
runs-on: ["self-hosted", "linux", "x64", "16xlarge+gpu"]
timeout-minutes: 60

Expand Down
14 changes: 13 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,19 @@ This will:

### Step 4: Use the Network

See [examples/README.md](examples/README.md) for how you can easily consume network addresses, parameters, etc. and hook them into Synapse, etc.
After startup, `USER_1` is fully configured for FOC: USDFC deposited into FilecoinPay and FWSS approved as an operator. You can use it immediately with synapse-sdk:

```bash
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README example runs node utils/example-storage-e2e.js ... without indicating that it must be executed from the synapse-sdk repo directory (or via a wrapper command). As written, this will fail for users running it from the foc-devnet repo root because utils/example-storage-e2e.js isn’t present there. Update the snippet to cd into ~/.foc-devnet/code/synapse-sdk (or document the correct working directory) before running the command.

Suggested change
```bash
```bash
cd ~/.foc-devnet/code/synapse-sdk

Copilot uses AI. Check for mistakes.
NETWORK=devnet node utils/example-storage-e2e.js <file>
```

All connection details (contract addresses, user keys, SP endpoints) are exported to `devnet-info.json`:

```bash
cat ~/.foc-devnet/state/latest/devnet-info.json
```

See [examples/README.md](examples/README.md) for more usage examples.

---

Expand Down
9 changes: 6 additions & 3 deletions README_ADVANCED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,9 +969,12 @@ Steps run sequentially by default, or in parallel when using the `--parallel` fl
- Approve authorized SPs
- Save provider IDs

**Synapse E2E Test Step:**
- Run end-to-end verification
- Test deal flow (unless `--notest` flag is used)
**Synapse E2E Test Step:** (skipped with `--notest`)
- Set up USER_1 for FOC: approve and deposit USDFC into FilecoinPay, approve FWSS as operator
- Export `devnet-info.json` to `~/.foc-devnet/run/<run-id>/devnet-info.json`
- Run synapse-sdk storage E2E test to verify the full deal flow
- After this step, USER_1 can interact with FOC storage services via synapse-sdk
- USER_2 and USER_3 are funded with USDFC but not configured for FOC

#### Post Start Steps
- Save step context
Expand Down
77 changes: 0 additions & 77 deletions scripts/cache-artifacts.sh
View file
Open in desktop

This file was deleted.

65 changes: 0 additions & 65 deletions scripts/deploy-mock-usdfc.sh
View file
Open in desktop

This file was deleted.

162 changes: 0 additions & 162 deletions scripts/patch-lotus-buildconstants.sh
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ pub enum Commands {
/// Run steps in parallel where possible (experimental)
#[arg(long)]
parallel: bool,
/// Skip the end-to-end tests
#[arg(long)]
notest: bool,
},
/// Stop the local cluster
Stop,
Expand All @@ -35,9 +32,6 @@ pub enum Commands {
/// Filecoin Services source location (e.g., 'gittag:v1.0.0', 'gittag:url:tag', 'gitcommit:abc123', 'gitcommit:url:commit', 'gitbranch:main', 'gitbranch:url:main', 'local:/path/to/filecoin-services')
#[arg(long)]
filecoin_services: Option<String>,
/// Synapse SDK source location (e.g., 'gittag:synapse-sdk-v0.36.1', 'gittag:url:tag', 'gitcommit:abc123', 'gitcommit:url:commit', 'gitbranch:main', 'gitbranch:url:branch', 'local:/path/to/synapse-sdk')
#[arg(long)]
synapse_sdk: Option<String>,
/// Yugabyte download URL
#[arg(long)]
yugabyte_url: Option<String>,
Expand Down
Loading