Skip to content

hot-fix(currency): adjust small decimal formatting logic#207

Open
abhinavdroid wants to merge 1 commit into
mainfrom
asana/compact-decimal-format-fix
Open

hot-fix(currency): adjust small decimal formatting logic#207
abhinavdroid wants to merge 1 commit into
mainfrom
asana/compact-decimal-format-fix

Conversation

@abhinavdroid
Copy link
Copy Markdown
Contributor

Description

Moved dynamic decimal precision handling into CurrencyUtil.formatNumber() to centralize formatting behavior and remove duplicate UI-level logic.

Examples:

  • 6 -> 6
  • 6.2 -> 6.2
  • 6.26 -> 6.26
  • 0.3 -> 0.3
  • 1250 -> 1.2K

Links :

Asana: https://app.asana.com/1/34125054317482/project/1200301693863971/task/1214652452633418?focus=true

Commits

  • Commit 1: hot-fix(currency): adjust small decimal formatting logic

Tests

I added the following tests:

No Test(s) added.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read and followed the Best Practices Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • Added relevant reviewers.

Breaking Change

  • No, no existing tests failed.
  • Yes, this is a breaking change.

Should be merge type:

  • Squash and merge
  • Rebase and merge

@abhinavdroid abhinavdroid added the bug Something isn't working label May 12, 2026
@abhinavdroid abhinavdroid force-pushed the asana/compact-decimal-format-fix branch from bef6b57 to 4ad8dd0 Compare May 12, 2026 08:39
@anujgupta-echocode
Copy link
Copy Markdown

🤖 AI PR Review

TL;DR: 🔴 Block merge — no test coverage and no documentation.
Verdict: BLOCK_MERGE

📋 Summary

  • Severity: 🔴 Critical 2 🔶 High 0 🟡 Medium 1 🔵 Low 0
  • Files analysed: 1 | Work items: 0 | Reverse deps: 3

Automated Quality Checks

🔴 Critical: No Test Coverage — 1 source file(s) changed/added but ZERO test files changed/added. Tests are mandatory for all code changes.

🔴 Critical: No Documentation — 1 source file(s) changed/added but no documentation updated. Update README, inline docs, or API docs for any code change.

🟡 Medium: No Reviewers Assigned — PR has zero reviewers. Add at least one peer reviewer before merging.

Deep Code Analysis

⚠️ Code analysis failed — the reviewer model returned no output despite loaded code context (retry budget exhausted, empty completion, or transient upstream error). Only automated quality checks are shown below; re-trigger the review or check the agent logs to investigate.

Changes

File Type
lib/src/utils/currency/helper.dart Edit

Reverse Dependencies (other repos calling this code)

  • FAModern Trade calls helper from /app/src/main/java/com/flick2know/fieldassist/moderntrade/common/helper/Helper.java
  • FA_Portal calls helper from /Field Assist Server/F2KLocationsNetwork_API_Role/Areas/DataCentre/Helper.cs
  • Portal_Sharded calls helper from /Field Assist Server/F2KLocationsNetwork_API_Role/Areas/DataCentre/Helper.cs

🔴 Critical   🔶 High   🟡 Medium   🔵 Low


Generated by FANexus PR Reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants