Sync SDK with API spec: float duration, live recording flag, playback access restrictions (v1.2.0) - #10
Open
rohit-fastpix wants to merge 10 commits into
Open
Sync SDK with API spec: float duration, live recording flag, playback access restrictions (v1.2.0)#10rohit-fastpix wants to merge 10 commits into
rohit-fastpix wants to merge 10 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FastPix Python SDK - Documentation PR
Documentation Changes
What Changed
tests/.env.exampleaddedFiles Modified
Summary
Brief description of changes:
Code Examples (if Applicable)
Testing
tests/test_examples.pypasses;examples/live_streaming.pyexercised against the dev workspacetests/check_broken_links.pyrun; only pre-existing external 404s remain (API base URLs that reject GET, one old changelog link)Review Checklist
Code Changes (summary)
Breaking
durationisOptional[float]seconds instead ofstr, onMedia,MediaClipResponseData,PlaylistCreatedSchemaMediaList,PlaylistByIDResponseMediaList— affectsget_media,list_media,list_live_clips,get_media_clips,updated_media,updated_source_access,updated_mp4_support, and playlistmediaListitems. Strict float, no legacy-string parsing.Added
enable_recording(defaultTrue) onInputMediaSettings.access_restrictionsonPlaybackIDRequest,PlaybackIDSuccessResponseData,PlaybackSettings, reusing the existingPlaybackIDAccessRestrictionsmodel; newaccess_restrictionskwarg oncreate_playback_id_of_stream.update_live_stream_domain_restrictions/update_live_stream_user_agent_restrictions(+_async) onLivePlayback, with new operation models.update_domain_restrictions/update_user_agent_restrictions.Fixed
_raise_for_status_asyncwithoutawait, so failed responses returnedNoneinstead of raising — fixed across all resource modules.datatype or a list where the SDK returns the{success, data}envelope; all now name the returned class.Tests
tests/test_models.py— model contract tests (duration,enableRecording,accessRestrictions, new op models, method presence).tests/test_async_errors.py— mocked-transport checks that async and sync methods raise typed errors on 4XX/5XX.tests/test_return_annotations.py— AST scan asserting every method's declared return type equals the class it unmarshals (144 cases).FASTPIX_BASE_URL; fixtures updated (flat restriction bodies,enableRecording,accessRestrictions); superseded TS validator and one-time scripts removed.Ready for review!