Skip to content

Bump tikv-jemallocator to 0.7 - #10

Merged
nuclearcat merged 1 commit into
mainfrom
bump-jemallocator-0.7
Sep 25, 2026
Merged

nuclearcat merged 1 commit into
mainfrom
bump-jemallocator-0.7

Conversation

@nuclearcat

Copy link
Copy Markdown
Collaborator

Fixes: #8

Copilot AI balanced review requested due to automatic review settings September 25, 2026 16:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

It is a narrowly scoped, verified dependency bump whose only code usage (the Jemalloc global allocator) and requested features remain compatible in the new version.

Review effort: Balanced
Findings: None

What changed in this PR

This PR upgrades the tikv-jemallocator global allocator dependency from 0.6 to 0.7, resolving issue #8 which noted the availability of the latest 0.7.0 release. netom uses jemalloc as its global allocator (instead of glibc malloc) so that freed pages are decayed back to the OS after large RIB/bmp-out dumps, keeping RSS from plateauing at the high-water mark. The upgrade also pulls in the underlying jemalloc bump (5.3.0 → 5.3.1 via tikv-jemalloc-sys 0.7.1).

Changes:

  • Bump tikv-jemallocator from 0.6 to 0.7 in Cargo.toml, retaining the profiling and background_threads_runtime_support features.
  • Update Cargo.lock to resolve tikv-jemallocator 0.7.0 / tikv-jemalloc-sys 0.7.1, with related transitive lockfile bumps (windows-sys, socket2).
File Description
Cargo.toml Updates the tikv-jemallocator version constraint to 0.7, keeping the same feature set.
Cargo.lock Records the resolved 0.7.0/0.7.1 versions and checksums, plus transitive dependency updates.

I verified that:

  • The only code usage of the crate is static GLOBAL: tikv_jemallocator::Jemalloc = tikv_jemallocator::Jemalloc; in src/main.rs:28, and the Jemalloc global-allocator API is unchanged in 0.7.
  • Both requested features (profiling, background_threads_runtime_support) still exist in the 0.7 line.
  • The Cargo.lock entries (versions, checksums, and dependency graph) are internally consistent with tikv-jemallocator 0.7.0 depending on tikv-jemalloc-sys 0.7.1.

No issues were found that warrant a comment.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nuclearcat
nuclearcat merged commit e8cd096 into main Sep 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Latest tikv/jemallocator release is 0.7.0 (May 2026)

2 participants