Bump tikv-jemallocator to 0.7 - #10
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
It is a narrowly scoped, verified dependency bump whose only code usage (the Jemalloc global allocator) and requested features remain compatible in the new version.
Review effort: Balanced
Findings: None
What changed in this PR
This PR upgrades the tikv-jemallocator global allocator dependency from 0.6 to 0.7, resolving issue #8 which noted the availability of the latest 0.7.0 release. netom uses jemalloc as its global allocator (instead of glibc malloc) so that freed pages are decayed back to the OS after large RIB/bmp-out dumps, keeping RSS from plateauing at the high-water mark. The upgrade also pulls in the underlying jemalloc bump (5.3.0 → 5.3.1 via tikv-jemalloc-sys 0.7.1).
Changes:
- Bump
tikv-jemallocatorfrom0.6to0.7inCargo.toml, retaining theprofilingandbackground_threads_runtime_supportfeatures. - Update
Cargo.lockto resolvetikv-jemallocator 0.7.0/tikv-jemalloc-sys 0.7.1, with related transitive lockfile bumps (windows-sys,socket2).
| File | Description |
|---|---|
| Cargo.toml | Updates the tikv-jemallocator version constraint to 0.7, keeping the same feature set. |
| Cargo.lock | Records the resolved 0.7.0/0.7.1 versions and checksums, plus transitive dependency updates. |
I verified that:
- The only code usage of the crate is
static GLOBAL: tikv_jemallocator::Jemalloc = tikv_jemallocator::Jemalloc;insrc/main.rs:28, and theJemallocglobal-allocator API is unchanged in0.7. - Both requested features (
profiling,background_threads_runtime_support) still exist in the0.7line. - The
Cargo.lockentries (versions, checksums, and dependency graph) are internally consistent withtikv-jemallocator 0.7.0depending ontikv-jemalloc-sys 0.7.1.
No issues were found that warrant a comment.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Fixes: #8