[SM64] Bleed independently implementation in materials#669
Open
Lilaa3 wants to merge 3 commits intoFast-64:mainfrom
Open
[SM64] Bleed independently implementation in materials#669Lilaa3 wants to merge 3 commits intoFast-64:mainfrom
Lilaa3 wants to merge 3 commits intoFast-64:mainfrom
Conversation
Lilaa3
added
enhancement
I don´t have to finish it today
Lilaa3
force-pushed
the
bleed-independent-per-material
branch
from
6616740 to
f155db6
Compare
Lilaa3
force-pushed
the
bleed-independent-per-material
branch
from
7b211b7 to
927094b
Compare
Collaborator
Author
|
I believe it was working last time I worked on this. But code may not be up to standard. Reviews welcome. |
Dragorn421
reviewed
Apr 10, 2026
Contributor
Dragorn421
left a comment
Dragorn421
left a comment
There was a problem hiding this comment.
bleeding is still wizardry to me!
| fMaterial.usedLights.append(key) | ||
| self.lights[key] = value | ||
|
|
||
| def dedup_name(self, name: str, names: list): |
Contributor
There was a problem hiding this comment.
Suggested change
| def dedup_name(self, name: str, names: list): | |
| def dedup_name(self, name: str, names: Container[str]): |
+ from collections.abc import Container
| loopDict = {} | ||
| for material_index, skinnedFaceArray in sorted(skinnedFaces.items()): | ||
| # These MUST be arrays (not dicts) as order is important | ||
| # TODO: in modern python dicts are ordered, is this really still needed? |
Contributor
There was a problem hiding this comment.
Blender 3.2 packs Python 3.10 and dicts are defined as ordered since python 3.7
|
|
||
| # while load mode is always written, they may not set the same range of values and therefor need revert | ||
| for revert_cmd in revert_other_load_cmd: | ||
| # try to find equivelent load othermode command in the current material and the previous material's revert |
Contributor
There was a problem hiding this comment.
Suggested change
| # try to find equivelent load othermode command in the current material and the previous material's revert | |
| # try to find equivalent load othermode command in the current material and the previous material's revert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don´t have time to finish it today.
This is UNFINISHED and does not work. it's just a proof of concept. Code also needs cleanup