Skip to content

Put main's preview lane one patch above the current release - #650

Merged
ChrisonSimtian merged 1 commit into
Fallout-build:mainfrom
ChrisonSimtian:fix/main-preview-version
Aug 19, 2026
Merged

Put main's preview lane one patch above the current release#650
ChrisonSimtian merged 1 commit into
Fallout-build:mainfrom
ChrisonSimtian:fix/main-preview-version

Conversation

@ChrisonSimtian

Copy link
Copy Markdown
Collaborator

Puts main's preview lane one patch above the current release instead of one minor above.

What changed

  • version.json: 10.5.0-preview.{height}10.4.1-preview.{height}. Latest GA is 10.4.0, so one patch above is 10.4.1.
  • release.versionIncrement: minorbuild. In Nerdbank.GitVersioning, build increments the third component. Left on minor, the next nbgv prepare-release would move main back to a minor bump and undo this.

Why

The rule is that main always sits one patch level above the current release. 10.5.0 claimed a minor that has not been planned or cut.

Verification

nbgv get-version on this branch:

Version:                      10.4.1
AssemblyInformationalVersion: 10.4.1-preview.1+317c5f4d83
NuGetPackageVersion:          10.4.1-preview.1.g317c5f4d83

version.json parses, and no test asserts the repo's version scheme. The 2026.1.0 strings in PublishPackageRouterSpecs and BuildGraphUtilitySpecs are fixtures for glob matching and version-string trimming, not assertions about this file.

Follow-up needed before this helps consumers

Three preview versions above 10.4.1 are already on the GitHub Packages feed, published from main before this change:

  • 10.5.0-preview.2.gace05f3695
  • 10.5.0-preview.8.g2b0d7ceb46
  • 10.5.0-preview.9.gc22ef81243

10.5.0-preview.9 sorts above 10.4.1-preview.N for every future N, so anyone resolving the newest prerelease keeps getting the 10 August build and never sees a new preview. Those three versions need deleting from GitHub Packages, on all 24 packages, for this change to take effect. Preview versions are disposable per ADR-0004, so deleting them is in line with the channel's contract.

Notes

  • release.branchName is release/{version}, which would create release/10.4, but the existing branch is release/v10.4 and publicReleaseRefSpec matches the v-prefixed form. Pre-existing mismatch, not touched here.
  • AGENTS.md and ADR-0004 still describe calendar versioning (YYYY.MINOR.PATCH). The repo has been on the 10.x line since 10.4.0, so those documents are already out of step. This PR follows the shipped reality and does not try to settle that.

`version.json` on `main` said `10.5.0-preview.{height}`, which is one *minor*
above the current release. The rule is one *patch* above: the latest GA is
`10.4.0`, so `main` publishes `10.4.1-preview.<height>`.

Also set `release.versionIncrement` to `build` so `nbgv prepare-release`
increments the patch component instead of the minor one. Leaving it on `minor`
would put the next cut back onto a minor bump and undo this on the next release.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@ChrisonSimtian ChrisonSimtian added bug Something isn't working target/vCurrent Targets the current version labels Aug 19, 2026
@ChrisonSimtian
ChrisonSimtian marked this pull request as ready for review August 19, 2026 08:22
@ChrisonSimtian
ChrisonSimtian merged commit 9467569 into Fallout-build:main Aug 19, 2026
1 check passed
@ChrisonSimtian
ChrisonSimtian deleted the fix/main-preview-version branch August 19, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working target/vCurrent Targets the current version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant