Put main's preview lane one patch above the current release - #650
Merged
ChrisonSimtian merged 1 commit intoAug 19, 2026
Merged
Conversation
`version.json` on `main` said `10.5.0-preview.{height}`, which is one *minor*
above the current release. The rule is one *patch* above: the latest GA is
`10.4.0`, so `main` publishes `10.4.1-preview.<height>`.
Also set `release.versionIncrement` to `build` so `nbgv prepare-release`
increments the patch component instead of the minor one. Leaving it on `minor`
would put the next cut back onto a minor bump and undo this on the next release.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ChrisonSimtian
marked this pull request as ready for review
August 19, 2026 08:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Puts
main's preview lane one patch above the current release instead of one minor above.What changed
version.json:10.5.0-preview.{height}→10.4.1-preview.{height}. Latest GA is10.4.0, so one patch above is10.4.1.release.versionIncrement:minor→build. In Nerdbank.GitVersioning,buildincrements the third component. Left onminor, the nextnbgv prepare-releasewould movemainback to a minor bump and undo this.Why
The rule is that
mainalways sits one patch level above the current release.10.5.0claimed a minor that has not been planned or cut.Verification
nbgv get-versionon this branch:version.jsonparses, and no test asserts the repo's version scheme. The2026.1.0strings inPublishPackageRouterSpecsandBuildGraphUtilitySpecsare fixtures for glob matching and version-string trimming, not assertions about this file.Follow-up needed before this helps consumers
Three preview versions above
10.4.1are already on the GitHub Packages feed, published frommainbefore this change:10.5.0-preview.2.gace05f369510.5.0-preview.8.g2b0d7ceb4610.5.0-preview.9.gc22ef8124310.5.0-preview.9sorts above10.4.1-preview.Nfor every futureN, so anyone resolving the newest prerelease keeps getting the 10 August build and never sees a new preview. Those three versions need deleting from GitHub Packages, on all 24 packages, for this change to take effect. Preview versions are disposable per ADR-0004, so deleting them is in line with the channel's contract.Notes
release.branchNameisrelease/{version}, which would createrelease/10.4, but the existing branch isrelease/v10.4andpublicReleaseRefSpecmatches thev-prefixed form. Pre-existing mismatch, not touched here.YYYY.MINOR.PATCH). The repo has been on the10.xline since10.4.0, so those documents are already out of step. This PR follows the shipped reality and does not try to settle that.