Add the Run Configuration view with build parameters - #18
Merged
Conversation
This was referenced Aug 14, 2026
ChrisonSimtian
force-pushed
the
feature/deployment-view
branch
from
August 14, 2026 23:49
92d6c2d to
464e75e
Compare
ChrisonSimtian
force-pushed
the
feature/run-config-parameters
branch
from
August 14, 2026 23:50
4a991d8 to
92dc0dc
Compare
ChrisonSimtian
changed the base branch from
feature/deployment-view
to
develop
August 16, 2026 12:00
A webview-view form in the Fallout container for the parameters a local run should pass, stored as `--name value` CLI arguments. Parameters live in workspaceState rather than settings: a run configuration describes *this* checkout (which configuration, which target framework), so it should not follow the user across workspaces or land in a committed settings.json where it would become everyone's default. Values are held as a name/value list and only rendered into an argument string at run time, so quoting is applied once, centrally — a value containing spaces is quoted and embedded quotes escaped, rather than each caller guessing. Nothing consumes the arguments yet; wiring them into the run flow is #14. Closes #12 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ChrisonSimtian
force-pushed
the
feature/run-config-parameters
branch
from
August 16, 2026 12:11
92dc0dc to
c63654f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4/6 of the #2 split. Closes #12. Based on #17.
A webview-view form in the Fallout container for the parameters a local run should pass, stored and rendered as
--name valueCLI arguments.Storage choice
Parameters live in
workspaceState, not settings. A run configuration describes this checkout — which configuration, which target framework — so it should not follow the user across workspaces, nor land in a committedsettings.jsonwhere it silently becomes everyone's default.Quoting
Values are held as a name/value list and only rendered into an argument string at run time, so quoting happens once, centrally: a value containing spaces is quoted and embedded quotes escaped. The alternative — storing a pre-rendered string — pushes that judgement onto every caller.
Nothing consumes the arguments yet; wiring them into the run flow is #14, kept separate so this PR is reviewable as "does the storage and form behave".
🤖 Generated with Claude Code