This repository was archived by the owner on Mar 10, 2026. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for JavaScript #59
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Add support for JavaScript #59
Changes from all commits
754f4123ad7900fbc512dFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dead code and misleading variable names in
add_symbolsfor class declarations.Two issues:
superclass_nodeis assigned but never used (confirmed by Ruff F841). Remove it.heritagebut it fetches the'body'field — misleading. It's also only used for theNonecheck on line 53, which is a defensive guard that's unlikely to trigger (classes without bodies are syntactically invalid JS).🔧 Proposed fix
def add_symbols(self, entity: Entity) -> None: if entity.node.type == 'class_declaration': - heritage = entity.node.child_by_field_name('body') - if heritage is None: + body = entity.node.child_by_field_name('body') + if body is None: return - superclass_node = entity.node.child_by_field_name('name') # Check for `extends` clause via class_heritage for child in entity.node.children:🧰 Tools
🪛 Ruff (0.15.1)
[error] 55-55: Local variable
superclass_nodeis assigned to but never usedRemove assignment to unused variable
superclass_node(F841)
🤖 Prompt for AI Agents
Check failure on line 180 in api/analyzers/source_analyzer.py
Uncontrolled data used in path expression
Check failure on line 180 in api/analyzers/source_analyzer.py
Uncontrolled data used in path expression
Check failure on line 180 in api/analyzers/source_analyzer.py
Uncontrolled data used in path expression
Check failure on line 180 in api/analyzers/source_analyzer.py
Uncontrolled data used in path expression
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
Uh oh!
There was an error while loading. Please reload this page.