Skip to content

hood angles will change depending on each prep#48

Merged
TaylerUva merged 2 commits into
mainfrom
37-add-logic-for-state-baseprep-and-prep
May 31, 2026
Merged

hood angles will change depending on each prep#48
TaylerUva merged 2 commits into
mainfrom
37-add-logic-for-state-baseprep-and-prep

Conversation

@JAMES-ROMERO123
Copy link
Copy Markdown
Contributor

james

james

Co-Authored-By: Justinpham17386769 <244249272+Justinpham17386769@users.noreply.github.com>
@JAMES-ROMERO123 JAMES-ROMERO123 requested a review from a team as a code owner May 31, 2026 00:30
@JAMES-ROMERO123 JAMES-ROMERO123 linked an issue May 31, 2026 that may be closed by this pull request
@TaylerUva TaylerUva requested a review from Copilot May 31, 2026 02:02
@TaylerUva TaylerUva enabled auto-merge (squash) May 31, 2026 02:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors shooter “prep” commands to support different flywheel speeds and hood angles per prep state, while standardizing prep behavior through a shared base command.

Changes:

  • Added per-location flywheel speed constants and per-location hood angle constants.
  • Introduced a BasePrep command and moved/created prep commands under commands.states.preps.
  • Renamed the rotors flywheel velocity setter API and updated call sites.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/main/java/frc/robot/subsystems/Rotors.java Renames flywheel velocity setter method.
src/main/java/frc/robot/constants/ConstRotors.java Adds preset flywheel speeds for multiple prep locations.
src/main/java/frc/robot/constants/ConstMotion.java Adds preset hood angles for multiple prep locations.
src/main/java/frc/robot/commands/states/Shooting.java Updates to the renamed flywheel setter method.
src/main/java/frc/robot/commands/states/PrepTrench.java Removes old stub prep command (migrated to preps).
src/main/java/frc/robot/commands/states/PrepTower.java Removes old stub prep command (migrated to preps).
src/main/java/frc/robot/commands/states/PrepOpponentToAlliance.java Removes old stub prep command (migrated to preps).
src/main/java/frc/robot/commands/states/PrepHub.java Removes old stub prep command (migrated to preps).
src/main/java/frc/robot/commands/states/PrepCorner.java Removes old stub prep command (migrated to preps).
src/main/java/frc/robot/commands/states/preps/BasePrep.java Adds shared prep behavior (set flywheel, hood, and robot state).
src/main/java/frc/robot/commands/states/preps/PrepTrench.java New trench prep using BasePrep with trench constants.
src/main/java/frc/robot/commands/states/preps/PrepTower.java New tower prep using BasePrep with tower constants.
src/main/java/frc/robot/commands/states/preps/PrepOpponentToAlliance.java New opponent-to-alliance prep using BasePrep with constants.
src/main/java/frc/robot/commands/states/preps/PrepNeutralToAlliance.java Moves/updates neutral-to-alliance prep to use BasePrep.
src/main/java/frc/robot/commands/states/preps/PrepHub.java New hub prep using BasePrep with hub constants.
src/main/java/frc/robot/commands/states/preps/PrepCorner.java New corner prep using BasePrep with corner constants.
src/main/java/frc/robot/commands/states/preps/PrepAnywhere.java Moves prep-anywhere command into preps package (currently still placeholder).
Comments suppressed due to low confidence (2)

src/main/java/frc/robot/commands/states/preps/PrepAnywhere.java:19

  • PrepAnywhere is still an empty placeholder command, so scheduling it will not set the flywheel speed, hood angle, or robot state like the other prep commands do. This likely defeats the purpose of the new per-prep hood/flywheel constants.
    src/main/java/frc/robot/commands/states/preps/PrepNeutralToAlliance.java:8
  • This file has an unused Command import, and the class Javadoc still references the old misspelled name ("PrepNeautralToAlliance").

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main/java/frc/robot/commands/states/preps/BasePrep.java
Comment thread src/main/java/frc/robot/commands/states/preps/BasePrep.java
Comment thread src/main/java/frc/robot/constants/ConstMotion.java
Comment thread src/main/java/frc/robot/commands/states/preps/PrepCorner.java
Comment thread src/main/java/frc/robot/commands/states/preps/PrepHub.java
Comment thread src/main/java/frc/robot/commands/states/preps/PrepTower.java
Copy link
Copy Markdown
Member

@TaylerUva TaylerUva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflicts

@TaylerUva TaylerUva merged commit ddea834 into main May 31, 2026
1 check passed
@TaylerUva TaylerUva deleted the 37-add-logic-for-state-baseprep-and-prep branch May 31, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add logic for state: BasePrep and Prep* (excluding PrepAnywhere)

4 participants