hood angles will change depending on each prep#48
Merged
Conversation
james Co-Authored-By: Justinpham17386769 <244249272+Justinpham17386769@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors shooter “prep” commands to support different flywheel speeds and hood angles per prep state, while standardizing prep behavior through a shared base command.
Changes:
- Added per-location flywheel speed constants and per-location hood angle constants.
- Introduced a
BasePrepcommand and moved/created prep commands undercommands.states.preps. - Renamed the rotors flywheel velocity setter API and updated call sites.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/frc/robot/subsystems/Rotors.java | Renames flywheel velocity setter method. |
| src/main/java/frc/robot/constants/ConstRotors.java | Adds preset flywheel speeds for multiple prep locations. |
| src/main/java/frc/robot/constants/ConstMotion.java | Adds preset hood angles for multiple prep locations. |
| src/main/java/frc/robot/commands/states/Shooting.java | Updates to the renamed flywheel setter method. |
| src/main/java/frc/robot/commands/states/PrepTrench.java | Removes old stub prep command (migrated to preps). |
| src/main/java/frc/robot/commands/states/PrepTower.java | Removes old stub prep command (migrated to preps). |
| src/main/java/frc/robot/commands/states/PrepOpponentToAlliance.java | Removes old stub prep command (migrated to preps). |
| src/main/java/frc/robot/commands/states/PrepHub.java | Removes old stub prep command (migrated to preps). |
| src/main/java/frc/robot/commands/states/PrepCorner.java | Removes old stub prep command (migrated to preps). |
| src/main/java/frc/robot/commands/states/preps/BasePrep.java | Adds shared prep behavior (set flywheel, hood, and robot state). |
| src/main/java/frc/robot/commands/states/preps/PrepTrench.java | New trench prep using BasePrep with trench constants. |
| src/main/java/frc/robot/commands/states/preps/PrepTower.java | New tower prep using BasePrep with tower constants. |
| src/main/java/frc/robot/commands/states/preps/PrepOpponentToAlliance.java | New opponent-to-alliance prep using BasePrep with constants. |
| src/main/java/frc/robot/commands/states/preps/PrepNeutralToAlliance.java | Moves/updates neutral-to-alliance prep to use BasePrep. |
| src/main/java/frc/robot/commands/states/preps/PrepHub.java | New hub prep using BasePrep with hub constants. |
| src/main/java/frc/robot/commands/states/preps/PrepCorner.java | New corner prep using BasePrep with corner constants. |
| src/main/java/frc/robot/commands/states/preps/PrepAnywhere.java | Moves prep-anywhere command into preps package (currently still placeholder). |
Comments suppressed due to low confidence (2)
src/main/java/frc/robot/commands/states/preps/PrepAnywhere.java:19
PrepAnywhereis still an empty placeholder command, so scheduling it will not set the flywheel speed, hood angle, or robot state like the other prep commands do. This likely defeats the purpose of the new per-prep hood/flywheel constants.
src/main/java/frc/robot/commands/states/preps/PrepNeutralToAlliance.java:8- This file has an unused
Commandimport, and the class Javadoc still references the old misspelled name ("PrepNeautralToAlliance").
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TaylerUva
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
james