made logic for shooting#45
Merged
Merged
Conversation
Co-Authored-By: Justinpham17386769 <244249272+Justinpham17386769@users.noreply.github.com>
Wu-Fan-529
reviewed
May 30, 2026
Wu-Fan-529
reviewed
May 30, 2026
Wu-Fan-529
reviewed
May 30, 2026
Co-Authored-By: Justinpham17386769 <244249272+Justinpham17386769@users.noreply.github.com>
Wu-Fan-529
previously requested changes
May 30, 2026
Co-Authored-By: Justinpham17386769 <244249272+Justinpham17386769@users.noreply.github.com>
TaylerUva
requested changes
May 30, 2026
…cessary else statement Co-Authored-By: Justinpham17386769 <244249272+Justinpham17386769@users.noreply.github.com>
TaylerUva
requested changes
May 30, 2026
Co-Authored-By: Justinpham17386769 <244249272+Justinpham17386769@users.noreply.github.com>
Co-Authored-By: Justinpham17386769 <244249272+Justinpham17386769@users.noreply.github.com>
Co-Authored-By: Justinpham17386769 <244249272+Justinpham17386769@users.noreply.github.com>
TaylerUva
requested changes
May 31, 2026
Member
TaylerUva
left a comment
TaylerUva
left a comment
There was a problem hiding this comment.
Read your code carefully and see if anything is not necessary. Think about how "shooting" works with the rest of the robot and the statemachine.
Co-Authored-By: Justinpham17386769 <244249272+Justinpham17386769@users.noreply.github.com>
TaylerUva
approved these changes
May 31, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears intended to implement/improve “shooting” behavior by introducing additional rotor/motion constants and shifting the Shooting command toward using the StateMachine.
Changes:
- Added new rotor constants for transfer roller speed and flywheel speed tolerance.
- Added a hood “retract” angle constant.
- Updated
Shootingcommand to setStateMachinestate and retract the hood on end (but removed flywheel/hood shooting setup logic).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/main/java/frc/robot/subsystems/Rotors.java |
No functional change (whitespace only). |
src/main/java/frc/robot/constants/ConstRotors.java |
Adds constants for transfer rollers speed and flywheel tolerance. |
src/main/java/frc/robot/constants/ConstMotion.java |
Adds a hood retract angle constant. |
src/main/java/frc/robot/commands/states/Shooting.java |
Alters shooting behavior; now sets robot state and runs feeder/transfer but no longer spins up the flywheel or sets the hood to the shooting angle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TaylerUva
approved these changes
May 31, 2026
…r rollers Co-Authored-By: Justinpham17386769 <244249272+Justinpham17386769@users.noreply.github.com>
TaylerUva
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.