Skip to content

Results panel: three P2 findings left open at the review repair limit (2026-09-19) #19

Description

@FORIFOR

From the closing ui-reviewer round on 2026-09-19 (verdict keep, P0 0, P1 0). Left open because the three-round repair limit of /ui-craft was reached, not because they are unimportant.

  1. The "chosen" tick on a file tab uses the same green ✓ as "checks passed", and can sit on an unverified file. Its meaning exists only in title/aria-label. Smallest fix: a different shape, or a short visible word such as 採用 / Chosen.
  2. The opened check record shows sha256 and check ids (html_basic, c2, "run_check … r2"). The sha256 label is UI text; the rest came from scripted test data. Either move the hash line to the detailed work record, give it an everyday label, or state in docs/design/brief.md that this disclosure is an exception.
  3. At 390px the "your selected version" pill stretches to full width and can look pressable. Keep it at text width.

Manual checks the reviewer asked for and nobody has done:

  • Keyboard only: Tab to an unverified file's tab, Enter, Tab to "未確認のまま、この版を使う", Enter. Record where focus goes once the button is replaced by the pill, and whether 「この版を使うことにしました。」 is announced.
  • Press 「確認の記録を見る」 with Enter: record that the disclosure opens, where the page scrolls, and where focus lands.
  • A real model run at 1440px: do strings like t2 or r1 reach teammate cards or the conversation?
  • Regular motion, a real iPhone, Firefox, 768px and 1100px, English by eye.

Evidence format and rules: docs/design/acceptance.md, docs/design/report-template.md.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions