Bump FOG_PLUGINS_VERSION to v1.6.13 - #1276
Merged
Merged
Conversation
Picks up FOGProject/fog-plugins#23, which routes all 25 plugin table builds through FOGManagerController::createTableSql() so their optional columns carry a DEFAULT (GH-1245). Schema step 348 repairs the tables an install already has; it cannot repair a plugin's, because createSql() runs as step 0 of the plugin's own schema() and so a plugin installed after the migration rebuilt its table the old way -- every optional column mandatory, and any INSERT omitting one failing with error 1364. Measured against a live 1.6 install, that release takes the bundled plugins from 29 columns carrying a default to 60, with the 52 left bare each bare for a stated reason. The seam it calls landed in #1275, which is on this branch, so the pin can move. Without that, a plugin install would die on Call to undefined method -- which is why the release notes say the two must move together. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up FOGProject/fog-plugins#23 (released as v1.6.13), which routes all 25 plugin table builds through
FOGManagerController::createTableSql()so their optional columns carry aDEFAULT. GH-1245.Schema step 348 repairs the tables an install already has. It cannot repair a plugin's:
createSql()runs as step 0 of the plugin's ownschema(), so a plugin installed after the migration rebuilt its table the old way — every optional column mandatory, and any INSERT omitting one failing witherror 1364.Measured against a live 1.6 install, across the 23 tables the probe can build:
The seam those plugins call landed in #1275, which is already on this branch — so the pin can move. Without it a plugin install would die on
Call to undefined method, which is why the release notes say the two have to move together.🤖 Generated with Claude Code