feat: add _iter_all_traces helper and rewrite manipulation notebook#18
Merged
feat: add _iter_all_traces helper and rewrite manipulation notebook#18
Conversation
def _iter_all_traces(fig: go.Figure) -> Iterator:
"""Iterate over all traces in a figure, including animation frames.
Yields traces from fig.data first, then from each frame in fig.frames.
Useful for applying styling to all traces including those in animations.
"""
yield from fig.data
for frame in fig.frames or []:
yield from frame.data
Refactored update_traces to use it (simpler now - removed the separate fig.update_traces() call):
for trace in _iter_all_traces(fig):
if selector is None:
trace.update(**kwargs)
else:
if all(getattr(trace, k, None) == v for k, v in selector.items()):
trace.update(**kwargs)
The helper can now be reused internally wherever trace iteration including animation frames is needed.
📝 WalkthroughWalkthroughThe pull request refactors a documentation notebook to demonstrate xarray-plotly with a 4D dataset example while introducing a centralized helper function for iterating over traces across animation frames, replacing duplicated iteration logic. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_iter_all_traces(fig)helper to iterate over all traces including animation framesupdate_traces()and_style_traces_as_bars()to use the new helpermanipulation.ipynbto usexpx()with a 4D DataArray demonstrating:facet_col/facet_rowupdate_tracessolution🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.