Skip to content

Top players matching 0 rated 0 games guys in 1v1 fix#315

Merged
Brutus5000 merged 1 commit into
FAForever:developfrom
K-ETFreeman:develop
May 31, 2026
Merged

Top players matching 0 rated 0 games guys in 1v1 fix#315
Brutus5000 merged 1 commit into
FAForever:developfrom
K-ETFreeman:develop

Conversation

@K-ETFreeman
Copy link
Copy Markdown
Contributor

@K-ETFreeman K-ETFreeman commented May 30, 2026

Fixes #314
Now 2ks will be able to play vs 1600 - 2600 rated players
The absolute worst case: new guys with 11 games (passes 10 games noob threshold) who played only vs the same uncertain (brand-new) opponents, they may go far lower (~1000 rating), but realistically this is quite unlikely to happen

Summary by CodeRabbit

  • Chores
    • Adjusted ladder search parameters to refine how the system discovers top players.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

📝 Walkthrough

Walkthrough

The PR reduces two ladder search tuning parameters in the FAF lobby server configuration from 1.0 to 0.5, constraining how far and granularly the system expands its top-player search during ranked matchmaking.

Changes

Ladder Search Expansion Configuration

Layer / File(s) Summary
Ladder search expansion parameters
apps/faf-lobby-server/config/config.yaml
LADDER_TOP_PLAYER_SEARCH_EXPANSION_MAX and LADDER_TOP_PLAYER_SEARCH_EXPANSION_STEP both decrease from 1.0 to 0.5, reducing the scope of top-player matching expansion.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A ladder tune so small and neat,
Two point-five drops make matches sweet,
No more skipping rated peaks,
Fair games found in 1v1 weeks! 🎮

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing matchmaking where top players are matched with inexperienced players by adjusting ladder search parameters.
Linked Issues check ✅ Passed The PR directly addresses issue #314 by reducing LADDER_TOP_PLAYER_SEARCH_EXPANSION_MAX and LADDER_TOP_PLAYER_SEARCH_EXPANSION_STEP from 1.0 to 0.5, exactly as specified in the issue.
Out of Scope Changes check ✅ Passed The PR contains only the necessary configuration changes to fix the matchmaking issue; no unrelated or out-of-scope modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Brutus5000 Brutus5000 merged commit 844fef5 into FAForever:develop May 31, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Top players matching noobs in 1v1 queue

2 participants