Skip to content

fix constant names #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OmerShubi merged 1 commit into from
Apr 6, 2026
Merged

fix constant names #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ python src/run/single_run/train.py +trainer=TrainerDL +model=RoberteyeWord +data
```

#### Multi-Run Pipeline (Production)
1. **Model checker**: `src/run/multi_run/model_checker.sh` - runs train+test for all model/data combinations
1. **Model checker**: `run_commands/utils/model_checker.sh` - runs train+test for all model/data combinations
2. **Sweep generation**: `src/run/multi_run/sweep_wrapper.sh` - creates hyperparameter sweeps
3. **Results processing**: `raw_to_processed_results.py` → `csv_to_latex.py` for paper tables

Expand Down Expand Up @@ -80,7 +80,7 @@ bash src/data/preprocessing/get_data.sh DATASET1,DATASET2 # Specific datasets
### Model Training/Testing Pipeline
```bash
# Quick model validation (recommended for development)
bash src/run/multi_run/model_checker.sh --data_tasks CopCo_TYP --folds 0,1 --cuda 0
bash run_commands/utils/model_checker.sh --data_tasks CopCo_TYP --folds 0,1 --cuda 0

# Full evaluation pipeline
bash src/run/multi_run/test_wrapper_creator.sh # Generates test scripts
Expand Down Expand Up @@ -109,4 +109,4 @@ python src/run/multi_run/csv_to_latex.py # Generate paper tables
- `results/`: Raw trial-level results and processed benchmark tables
- `logs/`: Completed/failed run tracking for multi-run experiments

When implementing features, follow the existing factory pattern and registration decorators. The codebase emphasizes reproducibility and cross-validation rigor for eye movement research.
When implementing features, follow the existing factory pattern and registration decorators. The codebase emphasizes reproducibility and cross-validation rigor for eye movement research.
5 changes: 2 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,8 @@ results/eyebench_benchmark_results/{metric}.csv
Implement `forward()` and `shared_step()` methods.
2. Register it in:

- `src/configs/enums.py` → `ModelNames`
- `src/configs/model_args.py` → model config class
- `src/configs/config.py` → `ModelMapping`
- `src/configs/constants.py` → `DLModelNames` (or `MLModelNames` for ML models)
- `src/configs/models/dl/YourModel.py` → model config class decorated with `@register_model_config` (use `src/configs/models/ml/` for ML models)

3. Define its default parameters and search space in `src/run/multi_run/search_spaces.py`.
4. Verify integration:
Expand Down
2 changes: 1 addition & 1 deletion docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ results/eyebench_benchmark_results/{metric}.csv
4. Verify integration:

```bash
bash src/run/multi_run/model_checker.sh
bash run_commands/utils/model_checker.sh
```

---
Expand Down
Loading