feat: Agent Ping Confirmation Callback API#309
feat: Agent Ping Confirmation Callback API#309saraichinwag wants to merge 1 commit intoExtra-Chill:mainfrom
Conversation
Implements REST endpoints for agent ping confirmation callbacks:
- POST /datamachine/v1/agent-ping/confirm - Receive completion status
- GET /datamachine/v1/agent-ping/callback/{id} - Poll for status
Features:
- Bearer token authentication (or localhost fallback)
- Duplicate detection (idempotent callbacks)
- Action hooks for downstream processing
- Comprehensive error handling
Closes Extra-Chill#308
chubes4
left a comment
chubes4
left a comment
There was a problem hiding this comment.
Feature is needed but implementation has issues:
-
wp_optionsas callback storage. Every ping creates an option (datamachine_agent_ping_callback_{id}). Options table isn't designed for high-volume transient data. No cleanup mechanism — these accumulate forever. Should use a transient with TTL, a custom table, or at minimum a scheduled cleanup. -
Missing
\prefix indata-machine.php:DataMachine\Api\AgentPing::register()should be\DataMachine\Api\AgentPing::register();with leading backslash and consistent indentation. -
Localhost auth bypass is fragile.
$_SERVER['REMOTE_ADDR']fallback is unreliable behind proxies/Cloudflare. Thex-real-ipheader check is good but the$_SERVERfallback should be removed or hardened. -
No callback TTL/expiry. Callbacks can be confirmed days later with no rejection window. Should expire after a reasonable period (1 hour? configurable?).
-
Formatting: Line ~248 has tabs mixed with spaces in the response array.
2 participants
Implements REST endpoints for agent ping confirmation callbacks. Closes #308