Skip to content

Fix cleanup for remote-tracking active worktrees#582

Merged
chubes4 merged 3 commits into
mainfrom
fix-clean-remote-active-worktrees
Jun 7, 2026
Merged

Fix cleanup for remote-tracking active worktrees#582
chubes4 merged 3 commits into
mainfrom
fix-clean-remote-active-worktrees

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented Jun 7, 2026

Summary

  • Canonicalize Data Machine Code-owned ability registrations to datamachine-code/* and remove the legacy datamachine/* alias shim.
  • Add active-no-signal-remote-clean-apply so clean active worktrees with no unpushed commits and an existing remote-tracking branch can be promoted to cleanup_eligible metadata.
  • Add the new remote-clean abandoned-cleanup stage before bounded deletion, with resume support and smoke coverage.

Testing

  • php tests/smoke-worktree-metadata-reconcile.php
  • php tests/smoke-worktree-cleanup-cli.php
  • php -l inc/Abilities/AbilityRegistry.php && php -l inc/Abilities/WorkspaceAbilities.php && php -l inc/Cli/Commands/WorkspaceCommand.php && php -l inc/Workspace/Workspace.php && php -l tests/smoke-worktree-cleanup-cli.php && php -l tests/smoke-worktree-metadata-reconcile.php && php -l tests/smoke-github-readonly-tools.php && php -l tests/smoke-github-pr-comment-tool.php && php -l tests/smoke-github-check-status-context.php && php -l tests/smoke-github-create-abilities.php
  • php tests/smoke-github-pr-comment-tool.php
  • php tests/smoke-github-check-status-context.php

Notes

  • php tests/smoke-github-readonly-tools.php still fails in the standalone harness because DataMachineCode\\Support\\PluginSettings is not loaded before configuration checks.
  • php tests/smoke-github-create-abilities.php still fails in the standalone harness because DataMachineCode\\Support\\PermissionHelper is not loaded before invoking permission callbacks.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Implemented the cleanup stage, ability namespace cleanup, and smoke test updates; Chris remains responsible for review and merge.

@homeboy-ci
Copy link
Copy Markdown
Contributor

homeboy-ci Bot commented Jun 7, 2026

Homeboy Results — data-machine-code

Lint

lint — failed

ℹ️ Auto-fix: homeboy lint data-machine-code --path /home/runner/work/data-machine-code/data-machine-code --changed-since 3ce82ca --fix (or homeboy refactor data-machine-code --path /home/runner/work/data-machine-code/data-machine-code --changed-since 3ce82ca --from lint --write)
ℹ️ Some issues may require manual fixes
ℹ️ Full options: homeboy docs commands/lint
ℹ️ Save lint baseline: homeboy lint data-machine-code --baseline
Deep dive: homeboy lint data-machine-code --changed-since 3ce82ca

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27082231760

Test

test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine-code --from lint --write
ℹ️ Collect coverage: homeboy test data-machine-code --coverage
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine-code --changed-since 3ce82ca

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27082231760

Audit

audit — passed

  • audit — 63 finding(s)
  • Total: 63 finding(s)

Deep dive: homeboy audit data-machine-code --changed-since 3ce82ca

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27082231760
Tooling versions
  • Homeboy CLI: homeboy 0.222.4+bf0e300
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: edf66ea6
  • Action: unknown@unknown

@chubes4
Copy link
Copy Markdown
Member Author

chubes4 commented Jun 7, 2026

Latest rerun status: Audit and Test pass. Lint still fails after the PHPCS fixes, but the remaining findings are PHPStan baseline drift in (for example unused constants and existing type/narrowing issues around older cleanup helpers). No PHPCS findings remain in the latest lint log.

@chubes4
Copy link
Copy Markdown
Member Author

chubes4 commented Jun 7, 2026

Latest rerun status: Audit and Test pass. Lint still fails after the PHPCS fixes, but the remaining findings are PHPStan baseline drift in inc/Workspace/Workspace.php (for example unused constants and existing type/narrowing issues around older cleanup helpers). No PHPCS findings remain in the latest lint log.

@chubes4 chubes4 merged commit 57dcac8 into main Jun 7, 2026
4 of 5 checks passed
@chubes4 chubes4 deleted the fix-clean-remote-active-worktrees branch June 7, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant