test: point react-native-onyx at onyx-init-hydrate branch - #98649
Draft
WojtekBoman wants to merge 1 commit into
Draft
test: point react-native-onyx at onyx-init-hydrate branch#98649WojtekBoman wants to merge 1 commit into
WojtekBoman wants to merge 1 commit into
Conversation
Contributor
|
|
Contributor
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Testing-only PR. Points the
react-native-onyxdependency at the branch of Expensify/react-native-onyx#821 so ad-hoc builds can be used to validate the change on real accounts.The Onyx change:
Onyx.init()loaded the persisted database intoOnyxCachethroughmerge(), which runsfastMerge(existing, value)per key. At init timeexistingis alwaysundefined, sofastMergenever merges anything - it just walks and deep-clones every nested object of every row. On a heavy account that clone-heavy cache-write phase measured ~29% of totalOnyx.init()time.PR 821 adds
OnyxCache.hydrate(), a bulk-load variant used only byOnyx.init(). Values are stored by reference when safe (utils.needsNormalization(), a read-only non-allocating check for nested null/undefined and the internal replace-object mark), and fall back to the existingfastMergepath when the key already has a cache value (a cross-tab sync listener can race ahead of init) or the value needs normalizing.Diff here is only the dependency reference:
package-lock.jsonpins the exact commit (25cf1cb277bfdb12e4b2f8ee301229753d955999), so CI and ad-hoc builds install that code and nothing later.Do not merge. Before anything ships,
react-native-onyxmust go back to a published version that contains the change.Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
Same as Tests above - primary goal is to confirm no data-integrity or startup regression on cold start with a heavy account.
PR Author Checklist
Screenshots/Videos
N/A - no UI change.