Spend - Canadian multiple tax export is not shown if an expense was previously deleted. - #98526
Open
dukenv0307 wants to merge 4 commits into
Open
Spend - Canadian multiple tax export is not shown if an expense was previously deleted.#98526dukenv0307 wants to merge 4 commits into
dukenv0307 wants to merge 4 commits into
Conversation
…reviously deleted.
dukenv0307
marked this pull request as ready for review
August 13, 2026 04:38
melvin-bot
Bot
requested review from
joekaufmanexpensify and
thelullabyy
and removed request for
a team
August 13, 2026 04:38
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
a team and
NikkiWines
and removed request for
a team
August 13, 2026 04:38
|
@NikkiWines Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
@thelullabyy pls review it |
NikkiWines
requested changes
Aug 13, 2026
NikkiWines
left a comment
Contributor
There was a problem hiding this comment.
👍 one small comment update
Co-authored-by: Nikki Wines <nikkiwines@expensify.com>
Contributor
Author
|
@thelullabyy can you please review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #98523
PROPOSAL:
Tests
Prerequisite: Account has at least one workspace with "CAD" as currency.
Offline tests
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-13.at.11.35.11.mov