Skip to content

Spend - Canadian multiple tax export is not shown if an expense was previously deleted. - #98526

Open
dukenv0307 wants to merge 4 commits into
Expensify:mainfrom
dukenv0307:fix/98523
Open

Spend - Canadian multiple tax export is not shown if an expense was previously deleted.#98526
dukenv0307 wants to merge 4 commits into
Expensify:mainfrom
dukenv0307:fix/98523

Conversation

@dukenv0307

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #98523
PROPOSAL:

Tests

Prerequisite: Account has at least one workspace with "CAD" as currency.

  1. Open the staging.new.expensify.com website.
  2. Navigate to workspace chat.
  3. Create a manual expense with "CAD" as currency.
  4. Navigate to "Spend" > "Expenses"
  5. Select the just created expense > Click on dropdown menu > "Export"
  6. Note that "Canadian multiple tax export" option is visible.
  7. Select and delete the expense.
  8. Navigate to workspace chat again.
  9. Create a new manual expense.
  10. Return to "Spend" > "Expenses"
  11. Select the just created expense > dropdown menu > "Export"
  12. Verify: "Canadian multiple tax export" option is visible for every expense displayed on a workspace with "CAD" as default currency.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as above

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-13.at.11.35.11.mov

@dukenv0307
dukenv0307 marked this pull request as ready for review August 13, 2026 04:38
@dukenv0307
dukenv0307 requested review from a team as code owners August 13, 2026 04:38
@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and thelullabyy and removed request for a team August 13, 2026 04:38
@melvin-bot

melvin-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from a team and NikkiWines and removed request for a team August 13, 2026 04:38
@melvin-bot

melvin-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

@NikkiWines Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 13, 2026 04:38
@dukenv0307

Copy link
Copy Markdown
Contributor Author

@thelullabyy pls review it

Comment thread src/hooks/useSearchBulkActions.ts Outdated

@NikkiWines NikkiWines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 one small comment update

Comment thread src/hooks/useSearchBulkActions.ts Outdated
Co-authored-by: Nikki Wines <nikkiwines@expensify.com>
@dukenv0307
dukenv0307 requested a review from NikkiWines August 13, 2026 11:12
@dukenv0307

Copy link
Copy Markdown
Contributor Author

@thelullabyy can you please review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants