Facelift: inset illustration in card section headers - #98517
Draft
shawnborton wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
@dannymcclain @dubielzyk-expensify can you give this one a spin once the builds finish? Do we still want to do this? I think it is a nice little improvement! |
Contributor
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
I like it. I don't feel super strongly about this one as to me it's not the slam dunk improvement. It's nice though, but I don't hate how it was either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Facelift pass on the big illustrated card headers rendered by the
Sectioncomponent.cardSectionIllustrationInsetstyle (12px top + horizontal margin,componentBorderRadiusNormal,overflow: hidden) applied as a default on theSectionillustration container. Every<Section illustration={...}>card header now shows the illustration as an inset, rounded panel instead of full-bleed.getEmptyStateCompanyCardsIllustrationnow returns{width: '100%', height: '100%'}on wide layouts so the illustration fills the inset panel edge-to-edge.GetStartedTravelandReviewingRequest) omitted the fixed illustration-header height, so its band was shorter than other pages with the same pattern. Addedstyles.cardSectionIllustrationContainer(matching the reference used elsewhere, e.g.DomainSamlPage) so the header renders at the standardsectionIllustrationHeight(220) with the illustration centered.Styling-only change; no logic or copy changes.
Fixed Issues
$
PROPOSAL:
Tests
Section(e.g. Settings → Security → Copilot, or a workspace Company Cards / Expensify Card empty state).Offline tests
Styling-only change; no offline-specific behavior.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari