Draft: Drop the vendorMatching beta gate from QBO vendor surfaces (R1 GA)

[KioCoan]

Explanation of Change

Vendor matching R1 (QuickBooks Online) has shipped and gone GA, so QBO code paths should no longer consult the vendorMatching beta. R2 (Sage Intacct) and R3 (Xero) are still pre-GA, so the beta stays in place and keeps gating those two integrations.

The whole change hinges on one idea: PolicyUtils.hasVendorFeature now short-circuits to true on isQBOVendorMatchingActive before the beta is consulted, and only consults it on the Intacct and Xero branches.

if (!policy) {
    return false;
}
if (isQBOVendorMatchingActive(policy)) {
    return true;
}
return isVendorMatchingBetaEnabled && (isIntacctVendorMatchingActive(policy) || isXeroVendorMatchingActive(policy));

Because of that, the nine cross-integration call sites (ViolationsUtils, MoneyRequestView, WorkspaceVendorsPage, WorkspaceInitialPage, WorkspaceMoreFeaturesPage, MerchantRulePageBase, AddVendorPage, IOURequestStepVendor) already route through hasVendorFeature and needed no edit. Only the gates that read the beta directly changed:

• DynamicQuickbooksCompanyCardExpenseAccountPage.tsx — a QBO-only page, so the beta conjunction is dropped outright and the now-unused usePermissions import is removed.
• WorkspaceMoreFeaturesPage/index.tsx — the whole Vendors toggle was wrapped in {isVendorMatchingEnabled && ...}, which would have hidden the row from non-beta QBO workspaces. It now uses shouldShowVendorsFeature = isVendorMatchingEnabled || hasVendorFeature(policy, isVendorMatchingEnabled), so beta members keep today's behavior (row always visible, active state from the connection) and everyone else sees it once QBO actually scopes the vendor field.
• The four usePolicyConnectionsPrefetch call sites — these passed the beta as enabled because policy.connections isn't loaded yet, so QBO-ness cannot be known at prefetch time. They now pass true (or just canReadVendors on WorkspaceInitialPage). This is safe and has precedent: the hook already self-guards on offline, no accounting connection, and already-fetched, and withPolicyConnections.tsx has always passed true unconditionally.

The two Xero-only pages (DynamicXeroExportConfigurationPage, DynamicXeroNonReimbursableDefaultContactSelectPage) are deliberately untouched, and CONST.BETAS.VENDOR_MATCHING stays because Xero and Sage Intacct still consume it.

Fixed Issues

https://github.com/Expensify/Expensify/issues/670049

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 764d3ba510

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/PolicyUtils.ts	77.69% <100.00%> (+0.03%)	⬆️
src/pages/workspace/WorkspaceInitialPage.tsx	0.00% <ø> (ø)
...ages/workspace/WorkspaceMoreFeaturesPage/index.tsx	69.70% <100.00%> (+0.08%)	⬆️
...DynamicQuickbooksCompanyCardExpenseAccountPage.tsx	0.00% <ø> (ø)
...space/rules/MerchantRules/MerchantRulePageBase.tsx	0.00% <ø> (ø)
...es/workspace/rules/MerchantRules/AddVendorPage.tsx	16.66% <0.00%> (ø)
... and 70 files with indirect coverage changes